pkg/compiler/lib/src/js_backend/codegen/task.dart - Issue 1486023002: Propagate types of static const variables.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_backend/codegen/task.dart

Issue 1486023002: Propagate types of static const variables. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/js_backend/codegen/task.dart

diff --git a/pkg/compiler/lib/src/js_backend/codegen/task.dart b/pkg/compiler/lib/src/js_backend/codegen/task.dart

index 870bba8b3c5157dba1aeb3cd7583c7f459743e2a..78887b0e910c6b50cc662693ad2c095a37180708 100644

--- a/pkg/compiler/lib/src/js_backend/codegen/task.dart

+++ b/pkg/compiler/lib/src/js_backend/codegen/task.dart

@@ -201,7 +201,7 @@ class CpsFunctionCompiler implements FunctionCompiler {

cps.FunctionDefinition optimizeCpsIr(cps.FunctionDefinition cpsFunction) {

cpsOptimizationTask.measure(() {

- TypeMaskSystem typeSystem = new TypeMaskSystem(compiler);

+ //TypeMaskSystem typeSystem = new TypeMaskSystem(compiler);

sra1 2015/12/01 05:07:30 Why did we create this shadowing definition?

asgerf 2015/12/01 08:36:57 Looks like a mistake. Please remove it.

applyCpsPass(new RedundantJoinEliminator(), cpsFunction);

applyCpsPass(new RedundantPhiEliminator(), cpsFunction);

« no previous file with comments | « pkg/compiler/lib/src/cps_ir/type_mask_system.dart ('k') | no next file » | no next file with comments »