Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 1486023002: Propagate types of static const variables. (Closed)

Created:
5 years ago by sra1
Modified:
5 years ago
Reviewers:
asgerf
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -2 lines) Patch
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/type_mask_system.dart View 2 chunks +16 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/task.dart View 1 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
sra1
This appears to work. Longer term I'd like the type inference to own the association. ...
5 years ago (2015-12-01 05:07:30 UTC) #3
asgerf
lgtm https://codereview.chromium.org/1486023002/diff/20001/pkg/compiler/lib/src/js_backend/codegen/task.dart File pkg/compiler/lib/src/js_backend/codegen/task.dart (right): https://codereview.chromium.org/1486023002/diff/20001/pkg/compiler/lib/src/js_backend/codegen/task.dart#newcode204 pkg/compiler/lib/src/js_backend/codegen/task.dart:204: //TypeMaskSystem typeSystem = new TypeMaskSystem(compiler); On 2015/12/01 05:07:30, ...
5 years ago (2015-12-01 08:36:57 UTC) #4
sra1
5 years ago (2015-12-01 20:03:43 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:40001) manually as
670f5b637cc57bb7887b25ac322dc72c7a56ce07 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698