Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 14860010: Android: Roll android_tools to b12d410c0ee23385da78e6c9f353d28fd992e0bd. (Closed)

Created:
7 years, 7 months ago by nilesh
Modified:
7 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Android: Roll android_tools to b12d410c0ee23385da78e6c9f353d28fd992e0bd. This change updates the ndk sources and toolchain to r8e http://developer.android.com/tools/sdk/ndk/index.html Also patching in https://chromiumcodereview.appspot.com/14840008/ to disable sincos optimization in third_party/mesa/ BUG= NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198936

Patch Set 1 #

Patch Set 2 : Disable 'sincos' optimization to avoid 'osmesa' link errors. #

Patch Set 3 : Not adding fno-builtin-sin for clang builds #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mesa/mesa.gyp View 1 2 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (0 generated)
nilesh
7 years, 7 months ago (2013-05-02 18:54:39 UTC) #1
nilesh
7 years, 7 months ago (2013-05-02 18:59:31 UTC) #2
Yaron
lgtm
7 years, 7 months ago (2013-05-02 19:01:16 UTC) #3
digit1
lgtm. By the way, I just uploaded https://chromiumcodereview.appspot.com/14820003/ to the deps/libvpx repository to get rid ...
7 years, 7 months ago (2013-05-02 19:15:25 UTC) #4
nilesh
@digit: clang build fails with. clang: error: argument unused during compilation: '-fno-builtin-sin'
7 years, 7 months ago (2013-05-02 20:33:42 UTC) #5
Yaron
On 2013/05/02 20:33:42, nilesh wrote: > @digit: clang build fails with. > > clang: error: ...
7 years, 7 months ago (2013-05-02 20:41:22 UTC) #6
Ken Russell (switch to Gerrit)
lgtm
7 years, 7 months ago (2013-05-02 20:54:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nileshagrawal@chromium.org/14860010/14001
7 years, 7 months ago (2013-05-02 21:54:28 UTC) #8
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) base_unittests, compile, content_unittests, crypto_unittests, googleurl_unittests, media_unittests, ...
7 years, 7 months ago (2013-05-02 22:40:52 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nileshagrawal@chromium.org/14860010/14001
7 years, 7 months ago (2013-05-02 23:24:49 UTC) #10
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) base_unittests, compile, content_unittests, crypto_unittests, googleurl_unittests, media_unittests, ...
7 years, 7 months ago (2013-05-02 23:45:25 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nileshagrawal@chromium.org/14860010/14001
7 years, 7 months ago (2013-05-03 01:14:59 UTC) #12
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) base_unittests, compile, content_unittests, crypto_unittests, googleurl_unittests, media_unittests, ...
7 years, 7 months ago (2013-05-03 01:32:33 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nileshagrawal@chromium.org/14860010/14001
7 years, 7 months ago (2013-05-03 17:15:54 UTC) #14
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) base_unittests, compile, content_unittests, crypto_unittests, googleurl_unittests, media_unittests, ...
7 years, 7 months ago (2013-05-03 17:26:20 UTC) #15
Yaron
On 2013/05/03 17:26:20, I haz the power (commit-bot) wrote: > Retried try job too often ...
7 years, 7 months ago (2013-05-08 16:49:56 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nileshagrawal@chromium.org/14860010/14001
7 years, 7 months ago (2013-05-08 16:50:42 UTC) #17
Yaron
digit: I saw those warnings when verifying locally. Can you land the vpx changes? (https://chromiumcodereview.appspot.com/14820003/)
7 years, 7 months ago (2013-05-08 16:50:46 UTC) #18
commit-bot: I haz the power
7 years, 7 months ago (2013-05-08 18:03:01 UTC) #19
Message was sent while issue was closed.
Change committed as 198936

Powered by Google App Engine
This is Rietveld 408576698