fix auto-delete bug that crept in with new fast blur path; is causing

fix auto-delete bug that crept in with new fast blur path; is causing
some of the valgrind errors.

BUG=skia:2111
Committed: http://code.google.com/p/skia/source/detail?r=13257

[humper, 2014-01-31 00:03:51]

The profile arrays were leaking; that should be fixed now.

However, this CL doesn't fix the whole problem, and I need to talk to Brian to
figure out how to fix it.

Brian -- the horizontal and vertical scanline textures that are created in
::Create -- where should those be released, and how?  These textures are cached
over the lifetime of the app, so that if other blurs come along with the same
dimensions we can reuse them without re-performing the computation.  Who is
responsible for deleting the textures that live in the cache?  According to the
bug report, the textures are leaking also.

[robertphillips, 2014-01-31 00:23:13]

https://codereview.chromium.org/148593003/diff/1/include/core/SkTemplates.h
File include/core/SkTemplates.h (right):

https://codereview.chromium.org/148593003/diff/1/include/core/SkTemplates.h#n...
include/core/SkTemplates.h:183: SkDELETE_ARRAY(fArray);
Move the assignment outside of the if block?

[robertphillips, 2014-01-31 00:24:29]

I retract that comment (must be getting tired).

lgtm

[robertphillips, 2014-01-31 00:37:29]

One option would be to model it on how the GrTextureStripAtlas handles its
texture.

[commit-bot: I haz the power, 2014-01-31 00:41:58]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/humper@google.com/148593003/1

[commit-bot: I haz the power, 2014-01-31 00:42:02]

Presubmit check for 148593003-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Since the CL is editing public API, you must have an LGTM from one of:
('reed@chromium.org', 'reed@google.com', 'bsalomon@chromium.org',
'bsalomon@google.com', 'rmistry@google.com')

[bsalomon, 2014-01-31 00:46:18]

On 2014/01/31 00:03:51, humper wrote:

> Brian -- the horizontal and vertical scanline textures that are created in
> ::Create -- where should those be released, and how?  These textures are
cached
> over the lifetime of the app, so that if other blurs come along with the same
> dimensions we can reuse them without re-performing the computation.  Who is
> responsible for deleting the textures that live in the cache?  According to
the
> bug report, the textures are leaking also.


Right... The createTexture or findAndRefTexture function will give you ownership
of ref on the texture. When you pass it into the effect subclass's constructor
and thereby into the GrTextureAccess the effect a ref as well which it will
release when the effect is destroyed. So after you construct the effect you
should unref the textures in the factory function. The cache will also have a
ref (until the texture is purged) so no need to worry about the texture being
destroyed prematurely. I guess one option is to make your CreateScanlineTextures
function take SkAutoTUnref<GrTexture>* so that the caller can't forget to unref.

[bsalomon, 2014-01-31 00:47:36]

lgtm

[commit-bot: I haz the power, 2014-01-31 00:47:47]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/humper@google.com/148593003/1

[commit-bot: I haz the power, 2014-01-31 01:00:51]

Change committed as 13257

[commit-bot: I haz the power, 2014-01-31 01:00:57]

CQ bit was unchecked on CL. Ignoring.