Source/core/page/EventHandler.cpp - Issue 14859016: Don't force layout for mouse event hit tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/EventHandler.cpp

Issue 14859016: Don't force layout for mouse event hit tests (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Add a test and check didFirstLayout() instead of shouldScheduleLayout(). And don't force layouts wh… Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/page/EventHandler.cpp

diff --git a/Source/core/page/EventHandler.cpp b/Source/core/page/EventHandler.cpp

index 7a90e841992d601f43985b89201f2a152bfe3283..8ba54c8ea9ef2da14b8a56e4ef912f1f4c8ee0ec 100644

--- a/Source/core/page/EventHandler.cpp

+++ b/Source/core/page/EventHandler.cpp

@@ -939,7 +939,7 @@ HitTestResult EventHandler::hitTestResultAtPoint(const LayoutPoint& point, HitTe

HitTestResult result(point, padding.height(), padding.width(), padding.height(), padding.width());

- if (!m_frame->contentRenderer())

+ if (!m_frame->contentRenderer() || !m_frame || !m_frame->view()->didFirstLayout())

jamesr 2013/05/14 03:03:44 no need to null-check m_frame just after dereferen

cbiesinger 2013/05/14 18:09:56 Whoops, that was supposed to check m_frame->view()

return result;

// hitTestResultAtPoint is specifically used to hitTest into all frames, thus it always allows child frame content.