Source/core/editing/Editor.h - Issue 14859008: Use a block cursor in overtype mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/Editor.h

Issue 14859008: Use a block cursor in overtype mode (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/editing/Editor.h

diff --git a/Source/core/editing/Editor.h b/Source/core/editing/Editor.h

index b7bf6892a5476b0b6f4f1adc1b1f40aae0f00b5d..63fd0dd49a07279de8546c694471f4ccfa7266af 100644

--- a/Source/core/editing/Editor.h

+++ b/Source/core/editing/Editor.h

@@ -212,7 +212,7 @@ public:

void markAndReplaceFor(PassRefPtr<SpellCheckRequest>, const Vector<TextCheckingResult>&);

bool isOverwriteModeEnabled() const { return m_overwriteModeEnabled; }

- void toggleOverwriteModeEnabled() { m_overwriteModeEnabled = !m_overwriteModeEnabled; }

+ void toggleOverwriteModeEnabled();

void markAllMisspellingsAndBadGrammarInRanges(TextCheckingTypeMask, Range* spellingRange, Range* grammarRange);