Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(625)

Unified Diff: Source/core/html/BaseMultipleFieldsDateAndTimeInputType.cpp

Issue 14859003: Remove the compile time flag for DATALIST Element. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/BaseMultipleFieldsDateAndTimeInputType.cpp
diff --git a/Source/core/html/BaseMultipleFieldsDateAndTimeInputType.cpp b/Source/core/html/BaseMultipleFieldsDateAndTimeInputType.cpp
index 701fddfe3025b7f1459506f9be5946c71f068d04..796c3ba9cdbd2f7425b8f5d594b887200761f5bc 100644
--- a/Source/core/html/BaseMultipleFieldsDateAndTimeInputType.cpp
+++ b/Source/core/html/BaseMultipleFieldsDateAndTimeInputType.cpp
@@ -307,10 +307,8 @@ void BaseMultipleFieldsDateAndTimeInputType::createShadowSubtree()
container->appendChild(spinButton);
bool shouldAddPickerIndicator = false;
-#if ENABLE(DATALIST_ELEMENT)
if (InputType::themeSupportsDataListUI(this))
shouldAddPickerIndicator = true;
-#endif
RefPtr<RenderTheme> theme = document->page() ? document->page()->theme() : RenderTheme::defaultTheme();
if (theme->supportsCalendarPicker(formControlType())) {
shouldAddPickerIndicator = true;
@@ -502,12 +500,10 @@ void BaseMultipleFieldsDateAndTimeInputType::valueAttributeChanged()
updateInnerTextValue();
}
-#if ENABLE(DATALIST_ELEMENT)
void BaseMultipleFieldsDateAndTimeInputType::listAttributeTargetChanged()
{
updatePickerIndicatorVisibility();
}
-#endif
void BaseMultipleFieldsDateAndTimeInputType::updatePickerIndicatorVisibility()
{
@@ -515,7 +511,6 @@ void BaseMultipleFieldsDateAndTimeInputType::updatePickerIndicatorVisibility()
showPickerIndicator();
return;
}
-#if ENABLE(DATALIST_ELEMENT)
if (HTMLDataListElement* dataList = element()->dataList()) {
RefPtr<HTMLCollection> options = dataList->options();
for (unsigned i = 0; HTMLOptionElement* option = toHTMLOptionElement(options->item(i)); ++i) {
@@ -526,7 +521,6 @@ void BaseMultipleFieldsDateAndTimeInputType::updatePickerIndicatorVisibility()
}
}
hidePickerIndicator();
-#endif
}
void BaseMultipleFieldsDateAndTimeInputType::hidePickerIndicator()

Powered by Google App Engine
This is Rietveld 408576698