Remove the compile time flag for DATALIST Element.

Source/core/rendering/RenderTheme.cpp

 /**
  * This file is part of the theme implementation for form controls in WebCore.
  *
  * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2012 Apple Computer, Inc.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
  * Library General Public License for more details.
  *
  * You should have received a copy of the GNU Library General Public License
  * along with this library; see the file COPYING.LIB.  If not, write to
  * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
  * Boston, MA 02110-1301, USA.
  */
 
 #include "config.h"
 #include "core/rendering/RenderTheme.h"
 
 #include "CSSValueKeywords.h"
 #include "HTMLNames.h"
+#include "RuntimeEnabledFeatures.h"
 #include "core/dom/Document.h"
 #include "core/editing/FrameSelection.h"
 #include "core/fileapi/FileList.h"
 #include "core/html/HTMLInputElement.h"
 #include "core/html/HTMLMeterElement.h"
 #include "core/html/shadow/MediaControlElements.h"
 #include "core/html/shadow/SpinButtonElement.h"
 #include "core/html/shadow/TextControlInnerElements.h"
 #include "core/page/FocusController.h"
 #include "core/page/Frame.h"
 #include "core/page/Page.h"
 #include "core/page/Settings.h"
 #include "core/platform/FileSystem.h"
 #include "core/platform/FloatConversion.h"
 #include "core/platform/LocalizedStrings.h"
 #include "core/platform/graphics/FontSelector.h"
 #include "core/platform/graphics/GraphicsContextStateSaver.h"
 #include "core/platform/graphics/StringTruncator.h"
 #include "core/rendering/PaintInfo.h"
 #include "core/rendering/RenderMeter.h"
 #include "core/rendering/RenderView.h"
 #include "core/rendering/style/RenderStyle.h"
 
 #if ENABLE(INPUT_SPEECH)
 #include "core/rendering/RenderInputSpeech.h"
 #endif
 
-#if ENABLE(DATALIST_ELEMENT)
 #include "core/dom/shadow/ElementShadow.h"

[tkent, 2013/05/21 21:05:44]

Merge these #includes to the above block.

 #include "core/html/HTMLCollection.h"
 #include "core/html/HTMLDataListElement.h"
 #include "core/html/HTMLOptionElement.h"
 #include "core/html/parser/HTMLParserIdioms.h"
-#endif
 
 // The methods in this file are shared by all themes on every platform.
 
 namespace WebCore {
 
 using namespace HTMLNames;
 
 static Color& customFocusRingColor()
 {
     DEFINE_STATIC_LOCAL(Color, color, ());
@@ skipping 377 matching lines @@
 #if ENABLE(INPUT_SPEECH)
     case InputSpeechButtonPart:
 #endif
     default:
         break;
     }
 
     return false;
 }
 
+String RenderTheme::extraDefaultStyleSheet()
+{
+    static String datalistElementCss = (RuntimeEnabledFeatures::dataListElementEnabled) ? "datalist {display: none ;}" : "";

[tkent, 2013/05/21 21:05:44]

Acronyms should be upper-case.  So the variable name should be
dataListElementCSS.
Also, please use ASCIILiteral notation.

+
+#if defined(ENABLE_INPUT_TYPE_COLOR) && ENABLE_INPUT_TYPE_COLOR

[tkent, 2013/05/21 21:05:44]

#if ENABLE(INPUT_TYPE_COLOR)

+    StringBuilder inputTypeCss;

[tkent, 2013/05/21 21:05:44]

Css -> CSS

+    inputTypeCss.append("input[type=\"color\"][list] { -webkit-appearance: menulist; width: 88px; height: 23px;}");
+    inputTypeCss.append("input[type=\"color\"][list]::-webkit-color-swatch-wrapper { padding-left: 8px; padding-right: 24px;}");
+    inputTypeCss.append("input[type=\"color\"][list]::-webkit-color-swatch { border-color: #000000;}");
+
+    return datalistElementCss + inputTypeCss.toString();

[tkent, 2013/05/21 21:05:44]

Because you already have a StringBuilder, use it.
inputTypeCSS.append(dataListElementCSS);
return inputTypeCSS.toString();

+#endif // defined(ENABLE_INPUT_TYPE_COLOR) && ENABLE_INPUT_TYPE_COLOR

[tkent, 2013/05/21 21:05:44]

This is a small #if block. I don't think we need a comment.

+
+    return datalistElementCss;
+}
+
 String RenderTheme::formatMediaControlsTime(float time) const
 {
     if (!std::isfinite(time))
         time = 0;
     int seconds = (int)fabsf(time);
     int hours = seconds / (60 * 60);
     int minutes = (seconds / 60) % 60;
     seconds %= 60;
     if (hours) {
         if (hours > 9)
@@ skipping 415 matching lines @@
 bool RenderTheme::supportsMeter(ControlPart) const
 {
     return false;
 }
 
 bool RenderTheme::paintMeter(RenderObject*, const PaintInfo&, const IntRect&)
 {
     return true;
 }
 
-#if ENABLE(DATALIST_ELEMENT)
 LayoutUnit RenderTheme::sliderTickSnappingThreshold() const
 {
     return 0;
 }
 
 void RenderTheme::paintSliderTicks(RenderObject* o, const PaintInfo& paintInfo, const IntRect& rect)
 {
     Node* node = o->node();
     if (!node)
         return;
@@ skipping 66 matching lines @@
         double tickFraction = (parsedValue - min) / (max - min);
         double tickRatio = isHorizontal && o->style()->isLeftToRightDirection() ? tickFraction : 1.0 - tickFraction;
         double tickPosition = round(tickRegionSideMargin + tickRegionWidth * tickRatio);
         if (isHorizontal)
             tickRect.setX(tickPosition);
         else
             tickRect.setY(tickPosition);
         paintInfo.context->fillRect(tickRect);
     }
 }
-#endif
 
 double RenderTheme::animationRepeatIntervalForProgressBar(RenderProgress*) const
 {
     return 0;
 }
 
 double RenderTheme::animationDurationForProgressBar(RenderProgress*) const
 {
     return 0;
 }
@@ skipping 195 matching lines @@
 
     return StringTruncator::centerTruncate(string, width, font, StringTruncator::EnableRoundingHacks);
 }
 
 bool RenderTheme::shouldOpenPickerWithF4Key() const
 {
     return false;
 }
 
 } // namespace WebCore