Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Issue 1485873002: Fix #includes in components/proximity_auth/cryptauth. (Closed)

Created:
5 years ago by Tim Song
Modified:
5 years ago
Reviewers:
sacomoto, brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix #includes in components/proximity_auth/cryptauth. To avoid a circular dependency with components/proximity_auth, we add separate switches.h/cc files. We also remove unneeded #includes to test_support files. BUG=562685, 562683 Committed: https://crrev.com/efaeb53caf95350b6d941bea7d3ccf4601b0db59 Cr-Commit-Position: refs/heads/master@{#362602}

Patch Set 1 : #

Patch Set 2 : fix compile for tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -24 lines) Patch
M components/proximity_auth.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M components/proximity_auth/cryptauth/BUILD.gn View 1 chunk +2 lines, -9 lines 0 comments Download
M components/proximity_auth/cryptauth/cryptauth_client_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/proximity_auth/cryptauth/cryptauth_client_impl_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/proximity_auth/cryptauth/cryptauth_enroller_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
A + components/proximity_auth/cryptauth/switches.h View 1 chunk +6 lines, -5 lines 0 comments Download
A components/proximity_auth/cryptauth/switches.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M components/proximity_auth/switches.h View 1 chunk +0 lines, -3 lines 0 comments Download
M components/proximity_auth/switches.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
Tim Song
5 years ago (2015-11-30 21:39:03 UTC) #2
brettw
LGTM, thanks!
5 years ago (2015-11-30 22:44:47 UTC) #4
sacomoto
lgtm
5 years ago (2015-12-01 15:35:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1485873002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1485873002/40001
5 years ago (2015-12-01 18:40:53 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/148230)
5 years ago (2015-12-01 18:52:47 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1485873002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1485873002/40001
5 years ago (2015-12-02 01:16:54 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years ago (2015-12-02 02:47:16 UTC) #13
commit-bot: I haz the power
5 years ago (2015-12-02 02:47:56 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/efaeb53caf95350b6d941bea7d3ccf4601b0db59
Cr-Commit-Position: refs/heads/master@{#362602}

Powered by Google App Engine
This is Rietveld 408576698