Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1485853003: Revert of Remove kuint16max. (Closed)

Created:
5 years ago by Avi (use Gerrit)
Modified:
5 years ago
CC:
chromium-reviews, tim+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, zea+watch_chromium.org, vmpstr+watch_chromium.org, maxbogue+watch_chromium.org, pvalenzuela+watch_chromium.org, plaree+watch_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@kint2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove kuint16max. (patchset #7 id:120001 of https://codereview.chromium.org/1475803002/ ) Reason for revert: missed one :( Original issue's description: > Remove kuint16max. > > BUG=138542 > > Committed: https://crrev.com/0d94fda8c494d7a6c27d065d782f42e99d834f46 > Cr-Commit-Position: refs/heads/master@{#362431} TBR=treib@chromium.org,mark@chromium.org,sergeyu@chromium.org,bartfab@chromium.org,rsleevi@chromium.org,sky@chromium.org,cpu@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=138542 Committed: https://crrev.com/911c3c05c6eb35562f354b5b4ddb57528141357f Cr-Commit-Position: refs/heads/master@{#362444}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -164 lines) Patch
M base/basictypes.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/webstore_installer.cc View 3 chunks +5 lines, -7 lines 0 comments Download
M chrome/browser/sync/test/integration/sync_test.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M components/policy/core/browser/url_blacklist_manager.cc View 5 chunks +4 lines, -8 lines 0 comments Download
M extensions/common/permissions/usb_device_permission_data.h View 4 chunks +10 lines, -11 lines 0 comments Download
M extensions/common/permissions/usb_device_permission_data.cc View 3 chunks +9 lines, -9 lines 0 comments Download
M jingle/notifier/communicator/single_login_attempt.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M net/dns/dns_session.h View 1 chunk +1 line, -1 line 0 comments Download
M net/dns/dns_session.cc View 3 chunks +4 lines, -9 lines 0 comments Download
M net/dns/dns_transaction_unittest.cc View 14 chunks +52 lines, -51 lines 0 comments Download
M net/test/spawned_test_server/base_test_server.cc View 3 chunks +3 lines, -6 lines 0 comments Download
M net/test/spawned_test_server/remote_test_server.cc View 3 chunks +3 lines, -8 lines 0 comments Download
M net/test/spawned_test_server/spawner_communicator.h View 4 chunks +4 lines, -5 lines 0 comments Download
M net/test/spawned_test_server/spawner_communicator.cc View 5 chunks +5 lines, -7 lines 0 comments Download
M net/tools/dns_fuzz_stub/dns_fuzz_stub.cc View 6 chunks +9 lines, -15 lines 0 comments Download
M sandbox/win/src/sandbox_nt_util.h View 4 chunks +5 lines, -9 lines 0 comments Download
M sandbox/win/src/sandbox_nt_util.cc View 5 chunks +6 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Avi (use Gerrit)
Created Revert of Remove kuint16max.
5 years ago (2015-12-01 17:19:28 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1485853003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1485853003/1
5 years ago (2015-12-01 17:19:41 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-01 17:21:13 UTC) #3
commit-bot: I haz the power
5 years ago (2015-12-01 17:22:04 UTC) #5
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/911c3c05c6eb35562f354b5b4ddb57528141357f
Cr-Commit-Position: refs/heads/master@{#362444}

Powered by Google App Engine
This is Rietveld 408576698