Drop [LegacyInterfaceTypeChecking] for most init*Event() methods

Drop [LegacyInterfaceTypeChecking] for most init*Event() methods

This will only affect cases where the argument provided but is neither null nor
an object of the required type. The main risk is therefore that people have
passed shifted all the arguments by accident, so that a boolean, string or
number is passed for one of the affected arguments.

Cases where undefined is passed or the argument is omitted entirely are not
affected, they behave just as if null were passed.

Also drop the *Arg suffix in arguments for initTextEvent().

BUG=561338
Committed: https://crrev.com/6fd2d82ef9ef4a19c6eeefa0ff8a486b0f22b43a
Cr-Commit-Position: refs/heads/master@{#362727}

[philipj_slow, 2015-12-02 12:23:30]

The CQ bit was checked by philipj@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2015-12-02 12:23:41]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1485833004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1485833004/20001

[philipj_slow, 2015-12-02 12:24:06]

Description was changed from

==========
Drop [LegacyInterfaceTypeChecking] for most init*Event() methods

BUG=561338
==========

to

==========
Drop [LegacyInterfaceTypeChecking] for most init*Event() methods

Also drop the *Arg suffix in arguments for initTextEvent().

BUG=561338
==========

[philipj_slow, 2015-12-02 13:42:50]

philipj@opera.com changed reviewers:
+ rbyers@chromium.org

[philipj_slow, 2015-12-02 13:42:51]

PTAL and CQ?

[commit-bot: I haz the power, 2015-12-02 14:03:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-02 14:03:57]

Dry run: This issue passed the CQ dry run.

[Rick Byers, 2015-12-02 14:39:24]

How would your characterize the compat risk of this?  It's not obvious to me
that it's trivial (but maybe I'm missing something).  In particular I'm thinking
of broken feature-detection logic similar to that at http://crbug.com/522100.  

I'll still support making this change, just wondering if we need an intent for
it?

[philipj_slow, 2015-12-02 14:48:10]

Description was changed from

==========
Drop [LegacyInterfaceTypeChecking] for most init*Event() methods

Also drop the *Arg suffix in arguments for initTextEvent().

BUG=561338
==========

to

==========
Drop [LegacyInterfaceTypeChecking] for most init*Event() methods

This will only affect cases where the argument provided but is neither null nor
an object of the required type. The main risk is therefore that people have
passed shifted all the arguments by accident, so that a boolean, string or
number is passed for one of the affected arguments.

Cases where undefined is passed or the argument is omitted entirely are not
affected, they behave just as if null were passed.

Also drop the *Arg suffix in arguments for initTextEvent().

BUG=561338
==========

[philipj_slow, 2015-12-02 14:52:24]

On 2015/12/02 14:39:24, Rick Byers wrote:
> How would your characterize the compat risk of this?  It's not obvious to me
> that it's trivial (but maybe I'm missing something).  In particular I'm
thinking
> of broken feature-detection logic similar to that at http://crbug.com/522100. 

> 
> I'll still support making this change, just wondering if we need an intent for
> it?

I've updated the description to say what I think that the risks are. It's
different to missing arguments for initTouchEvent() in that you'd have to try to
pass an argument and get it wrong. I think this is small enough to skip the
process and even too small for a PSA.

I do, however, think that making any init*Event() arguments non-optional
warrants an Intent to Ship, and I've been thinking that I should do that for at
least the init*Event() methods where there's already at least one other engine
requiring the arguments.

[Rick Byers, 2015-12-02 16:14:08]

Thanks for the details.  I agree this qualifies as "trivial" - it's really just
a bugfix that (like most bugfixes to API behavior) is relatively unlikely to
cause compat issues.  LGTM.

[Rick Byers, 2015-12-02 16:14:14]

The CQ bit was checked by rbyers@chromium.org

[commit-bot: I haz the power, 2015-12-02 16:14:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1485833004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1485833004/20001

[commit-bot: I haz the power, 2015-12-02 16:19:45]

Description was changed from

==========
Drop [LegacyInterfaceTypeChecking] for most init*Event() methods

This will only affect cases where the argument provided but is neither null nor
an object of the required type. The main risk is therefore that people have
passed shifted all the arguments by accident, so that a boolean, string or
number is passed for one of the affected arguments.

Cases where undefined is passed or the argument is omitted entirely are not
affected, they behave just as if null were passed.

Also drop the *Arg suffix in arguments for initTextEvent().

BUG=561338
==========

to

==========
Drop [LegacyInterfaceTypeChecking] for most init*Event() methods

This will only affect cases where the argument provided but is neither null nor
an object of the required type. The main risk is therefore that people have
passed shifted all the arguments by accident, so that a boolean, string or
number is passed for one of the affected arguments.

Cases where undefined is passed or the argument is omitted entirely are not
affected, they behave just as if null were passed.

Also drop the *Arg suffix in arguments for initTextEvent().

BUG=561338
==========

[commit-bot: I haz the power, 2015-12-02 16:19:46]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-02 16:20:34]

Description was changed from

==========
Drop [LegacyInterfaceTypeChecking] for most init*Event() methods

This will only affect cases where the argument provided but is neither null nor
an object of the required type. The main risk is therefore that people have
passed shifted all the arguments by accident, so that a boolean, string or
number is passed for one of the affected arguments.

Cases where undefined is passed or the argument is omitted entirely are not
affected, they behave just as if null were passed.

Also drop the *Arg suffix in arguments for initTextEvent().

BUG=561338
==========

to

==========
Drop [LegacyInterfaceTypeChecking] for most init*Event() methods

This will only affect cases where the argument provided but is neither null nor
an object of the required type. The main risk is therefore that people have
passed shifted all the arguments by accident, so that a boolean, string or
number is passed for one of the affected arguments.

Cases where undefined is passed or the argument is omitted entirely are not
affected, they behave just as if null were passed.

Also drop the *Arg suffix in arguments for initTextEvent().

BUG=561338

Committed: https://crrev.com/6fd2d82ef9ef4a19c6eeefa0ff8a486b0f22b43a
Cr-Commit-Position: refs/heads/master@{#362727}
==========

[commit-bot: I haz the power, 2015-12-02 16:20:34]

Patchset 2 (id:??) landed as
https://crrev.com/6fd2d82ef9ef4a19c6eeefa0ff8a486b0f22b43a
Cr-Commit-Position: refs/heads/master@{#362727}