Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 1485833003: MIPS:[turbofan] Use Nor instruction for bit negation instead of xori. (Closed)

Created:
5 years ago by dusan.milosavljevic
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS:[turbofan] Use Nor instruction for bit negation instead of xori. Xori instruction can only have unisgned 16-bit immediates for right input, as such it is not suitable for bit negation on mips. TEST=unittests/InstructionSecetorTest.Word(32|64)XorMinusOneWithParameter BUG= Committed: https://crrev.com/6b11cc830b41f3d80c26e42d93bceb4ebc6910a6 Cr-Commit-Position: refs/heads/master@{#32478}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -2 lines) Patch
M src/compiler/mips/code-generator-mips.cc View 1 chunk +6 lines, -1 line 0 comments Download
M src/compiler/mips/instruction-selector-mips.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 1 chunk +6 lines, -1 line 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 2 chunks +14 lines, -0 lines 0 comments Download
M test/unittests/compiler/mips/instruction-selector-mips-unittest.cc View 1 chunk +22 lines, -0 lines 0 comments Download
M test/unittests/compiler/mips64/instruction-selector-mips64-unittest.cc View 1 chunk +44 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
dusan.milosavljevic
PTAL.
5 years ago (2015-12-01 16:15:33 UTC) #2
titzer
On 2015/12/01 16:15:33, dusan.milosavljevic wrote: > PTAL. lgtm
5 years ago (2015-12-01 16:21:15 UTC) #3
paul.l...
lgtm
5 years ago (2015-12-01 17:49:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1485833003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1485833003/1
5 years ago (2015-12-01 21:37:44 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-01 21:57:59 UTC) #7
commit-bot: I haz the power
5 years ago (2015-12-01 21:58:51 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6b11cc830b41f3d80c26e42d93bceb4ebc6910a6
Cr-Commit-Position: refs/heads/master@{#32478}

Powered by Google App Engine
This is Rietveld 408576698