Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(651)

Issue 148583013: Updated expected_deps_{i386,x86_64} to match actual deps. (Closed)

Created:
6 years, 10 months ago by Scott Hess - ex-Googler
Modified:
6 years, 10 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews, grt+watch_chromium.org, haitaol
Visibility:
Public.

Description

Updated expected_deps_{i386,x86_64} to match actual deps. Dependencies added in the range 247500-247514. I suspect 247509, a blink roll. BUG=None NOTRY=true NOTREECHECKS=true TBR=phajdan.jr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247567

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/installer/linux/rpm/expected_deps_i386 View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/installer/linux/rpm/expected_deps_x86_64 View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Scott Hess - ex-Googler
Sorry for the delay - the box I was doing it on went byebye.
6 years, 10 months ago (2014-01-29 00:45:47 UTC) #1
Paweł Hajdan Jr.
LGTM
6 years, 10 months ago (2014-01-29 01:05:15 UTC) #2
Scott Hess - ex-Googler
OK, I'm going to push the button, then I'll try to remember to check later ...
6 years, 10 months ago (2014-01-29 01:12:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shess@chromium.org/148583013/1
6 years, 10 months ago (2014-01-29 01:13:52 UTC) #4
commit-bot: I haz the power
Change committed as 247567
6 years, 10 months ago (2014-01-29 01:26:27 UTC) #5
jln (very slow on Chromium)
It's still complaining: http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux%20x64/builds/47878/steps/compile/logs/stdio Packaging x86_64... 2d1 < ld-linux-x86-64.so.2(GLIBC_2.2.5)(64bit) ERROR: Shared library dependencies changed! If ...
6 years, 10 months ago (2014-01-29 03:15:13 UTC) #6
Adam Rice
A revert of this CL has been created in https://codereview.chromium.org/149203005/ by ricea@chromium.org. The reason for ...
6 years, 10 months ago (2014-01-29 03:33:54 UTC) #7
Lei Zhang
FYI, the root cause is http://src.chromium.org/viewvc/blink?view=revision&revision=165896 ThreadState.cpp calls pthread_attr_getstack() and pthread_getattr_np().
6 years, 10 months ago (2014-01-29 10:59:31 UTC) #8
Scott Hess - ex-Googler
6 years, 10 months ago (2014-01-29 15:36:04 UTC) #9
Message was sent while issue was closed.
On 2014/01/29 03:15:13, jln wrote:
> It's still complaining:
> 
>
http://build.chromium.org/p/chromium.chrome/builders/Google%2520Chrome%2520Li...
> 
> Packaging x86_64...
> 2d1
> < ld-linux-x86-64.so.2(GLIBC_2.2.5)(64bit)
> 
> ERROR: Shared library dependencies changed!
> If this is intentional, please update:
> chrome/installer/linux/rpm/expected_deps_i386
> chrome/installer/linux/rpm/expected_deps_x86_64
> 
> I have no idea why.

Yeah, it's because the original failure was actually the blink roll.  That's
what I figured it was going to be, but Pawel was pretty insistent on just
rolling the expectations change and not spending time on it... apologies for not
circling back, later, someday I'll realize that families soak up your entire
evening ...

Powered by Google App Engine
This is Rietveld 408576698