Issue 148583002: move getAdvancedTypefaceMetrics into private, as only skia internals call it

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 148583002: move getAdvancedTypefaceMetrics into private, as only skia internals call it (Closed)

Created:
6 years, 11 months ago by reed1

Modified:
6 years, 11 months ago

Reviewers:
bungeman-skia, vandebo (ex-Chrome), hal.canary

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

move getAdvancedTypefaceMetrics into private, as only skia internals call it BUG=skia: R=bungeman@google.com, vandebo@chromium.org Committed: https://code.google.com/p/skia/source/detail?r=13206

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -15 lines)			Patch
	M	include/core/SkTypeface.h	View		2 chunks	+20 lines, -15 lines	0 comments	Download

Total messages: 5 (0 generated)

bungeman-skia

lgtm, I don't see it being used in Chromium anymore.

6 years, 11 months ago (2014-01-27 20:37:53 UTC) #2

reed1

On 2014/01/27 20:56:34, vandebo wrote: > LGTM > > Should the header file get moved ...

6 years, 11 months ago (2014-01-27 21:01:58 UTC) #4

reed1

6 years, 11 months ago (2014-01-27 21:02:19 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r13206 (presubmit successful).