Remove the record_full_layer layer tree setting.

Remove the record_full_layer layer tree setting.

Blink now implements the same thing in its interest rect code.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/7e19cf539647c023733a4ceef45694eed5322bf8
Cr-Commit-Position: refs/heads/master@{#363012}

[chrishtr, 2015-12-01 21:10:55]

Description was changed from

==========
none

BUG=
==========

to

==========
none

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[chrishtr, 2015-12-01 21:12:17]

Description was changed from

==========
none

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Remove the record_full_layer layer tree setting.

Blink now implements the same thing in its interest rect code.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[chrishtr, 2015-12-01 21:13:07]

chrishtr@chromium.org changed reviewers:
+ enne@chromium.org

[enne (OOO), 2015-12-01 22:40:33]

https://codereview.chromium.org/1485823005/diff/1/content/renderer/render_wid...
File content/renderer/render_widget.cc (left):

https://codereview.chromium.org/1485823005/diff/1/content/renderer/render_wid...
content/renderer/render_widget.cc:2156: bool RenderWidget::DoesRecordFullLayer()
const {
Is this not used anywhere in Android?

[chrishtr, 2015-12-01 22:52:17]

chrishtr@chromium.org changed reviewers:
+ aelias@chromium.org

[chrishtr, 2015-12-01 22:52:17]

https://codereview.chromium.org/1485823005/diff/1/content/renderer/render_wid...
File content/renderer/render_widget.cc (left):

https://codereview.chromium.org/1485823005/diff/1/content/renderer/render_wid...
content/renderer/render_widget.cc:2156: bool RenderWidget::DoesRecordFullLayer()
const {
On 2015/12/01 at 22:40:33, enne wrote:
> Is this not used anywhere in Android?

Not 100% sure. Alex?

[aelias_OOO_until_Jul13, 2015-12-01 23:17:50]

It's used by Android WebView from android_webview/native/aw_settings.cc to
support enableSlowWholeDocumentDraw() public API.  This is used by Google Books
to perform software draws of pages far outside the current viewport.  Probably
Android WebView target doesn't compile with this removal?

[chrishtr, 2015-12-02 19:16:06]

On 2015/12/01 at 23:17:50, aelias wrote:
> It's used by Android WebView from android_webview/native/aw_settings.cc to
support enableSlowWholeDocumentDraw() public API.  This is used by Google Books
to perform software draws of pages far outside the current viewport.  Probably
Android WebView target doesn't compile with this removal?

aw_settings.cc sets WebPrefrences.record_whole_document, but as far as I can
tell it does not call DoesRecordFullLayer() in RenderWidget. I've already
committed a patch to make Blink respect WebPrefrences.record_whole_document.
This CL removes now-unnecessary plumbing into cc.

 FWIW the try jobs on this CL succeeded, not sure if there is a webview compile
try job.

[chrishtr, 2015-12-02 19:17:29]

On 2015/12/02 at 19:16:06, chrishtr wrote:
> On 2015/12/01 at 23:17:50, aelias wrote:
> > It's used by Android WebView from android_webview/native/aw_settings.cc to
support enableSlowWholeDocumentDraw() public API.  This is used by Google Books
to perform software draws of pages far outside the current viewport.  Probably
Android WebView target doesn't compile with this removal?
> 
> aw_settings.cc sets WebPrefrences.record_whole_document, but as far as I can
tell it does not call DoesRecordFullLayer() in RenderWidget. I've already
committed a patch to make Blink respect WebPrefrences.record_whole_document.
This CL removes now-unnecessary plumbing into cc.
> 
>  FWIW the try jobs on this CL succeeded, not sure if there is a webview
compile try job.

danakj reports that there is a CQ-blocking webview compile trybot. So I guess
it's ok as long as it compiles?

[aelias_OOO_until_Jul13, 2015-12-02 19:58:29]

Sounds good, should be fine then.  lgtm

[chrishtr, 2015-12-02 21:39:22]

The CQ bit was checked by chrishtr@chromium.org

[commit-bot: I haz the power, 2015-12-02 21:40:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1485823005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1485823005/1

[commit-bot: I haz the power, 2015-12-02 22:22:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-02 22:22:10]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[chrishtr, 2015-12-02 22:32:09]

chrishtr@chromium.org changed reviewers:
+ dtrainor@chromium.org, kinuko@chromium.org

[chrishtr, 2015-12-02 22:32:09]

dtrainor: need LGTM for blimp/.

kinuko: need LGTM for content/renderer/

[kinuko, 2015-12-03 02:53:53]

On 2015/12/02 22:32:09, chrishtr wrote:
> dtrainor: need LGTM for blimp/.
> 
> kinuko: need LGTM for content/renderer/

lgtm for content/renderer

[David Trainor- moved to gerrit, 2015-12-03 03:18:06]

blimp/ lgtm

[chrishtr, 2015-12-03 16:59:35]

The CQ bit was checked by chrishtr@chromium.org

[commit-bot: I haz the power, 2015-12-03 17:00:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1485823005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1485823005/1

[commit-bot: I haz the power, 2015-12-03 18:30:10]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-12-03 18:30:55]

Description was changed from

==========
Remove the record_full_layer layer tree setting.

Blink now implements the same thing in its interest rect code.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Remove the record_full_layer layer tree setting.

Blink now implements the same thing in its interest rect code.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/7e19cf539647c023733a4ceef45694eed5322bf8
Cr-Commit-Position: refs/heads/master@{#363012}
==========

[commit-bot: I haz the power, 2015-12-03 18:30:56]

Patchset 1 (id:??) landed as
https://crrev.com/7e19cf539647c023733a4ceef45694eed5322bf8
Cr-Commit-Position: refs/heads/master@{#363012}