Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1485823003: [cleanup] Remove cruft from old rest parameter implementation (Closed)

Created:
5 years ago by adamk
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[cleanup] Remove cruft from old rest parameter implementation Committed: https://crrev.com/3aa862896bd19c6b175f9576e6e8c7a41707429e Cr-Commit-Position: refs/heads/master@{#32535}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -15 lines) Patch
M src/ast/ast-value-factory.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/ast/scopes.h View 2 chunks +0 lines, -12 lines 0 comments Download
M src/ast/scopes.cc View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
adamk
5 years ago (2015-11-30 23:25:46 UTC) #2
caitp (gmail)
looks alright to me
5 years ago (2015-11-30 23:30:02 UTC) #3
adamk
+littledan
5 years ago (2015-12-02 22:25:24 UTC) #5
Dan Ehrenberg
lgtm
5 years ago (2015-12-02 22:38:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1485823003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1485823003/1
5 years ago (2015-12-02 22:39:14 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: v8_win_compile_dbg on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_compile_dbg/builds/10491)
5 years ago (2015-12-02 22:42:49 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1485823003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1485823003/1
5 years ago (2015-12-02 22:53:44 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-02 23:45:33 UTC) #13
commit-bot: I haz the power
5 years ago (2015-12-02 23:45:58 UTC) #15
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/3aa862896bd19c6b175f9576e6e8c7a41707429e
Cr-Commit-Position: refs/heads/master@{#32535}

Powered by Google App Engine
This is Rietveld 408576698