Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 1485823002: Revert of [heap] Aggressive code flushing in GC stress mode. (Closed)

Created:
5 years ago by Michael Starzinger
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_cleanup-code-flushing-1
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [heap] Aggressive code flushing in GC stress mode. (patchset #1 id:1 of https://codereview.chromium.org/1483993002/ ) Reason for revert: This breaks (surprise) GC stress with custom snapshot, cannot reproduce, will need to investigate further. https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/builds/2909/steps/Mjsunit/logs/deopt-inlined-from-call Original issue's description: > [heap] Aggressive code flushing in GC stress mode. > > This disregards the code age heuristic when deciding whether to flush > code so that GC stress mode is more likely to flush out potential races > between our various "invariants". > > R=hpayer@chromium.org > > Committed: https://crrev.com/28a3f23e50f1847dd1152e6bb4aa0579acbdaaab > Cr-Commit-Position: refs/heads/master@{#32414} TBR=hpayer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/44d4131c728df42a4826e6553e58d81b414c20c6 Cr-Commit-Position: refs/heads/master@{#32416}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -10 lines) Patch
M src/heap/objects-visiting-inl.h View 2 chunks +5 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Starzinger
Created Revert of [heap] Aggressive code flushing in GC stress mode.
5 years ago (2015-11-30 19:09:28 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1485823002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1485823002/1
5 years ago (2015-11-30 19:09:30 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-30 19:09:46 UTC) #4
commit-bot: I haz the power
5 years ago (2015-11-30 19:10:40 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/44d4131c728df42a4826e6553e58d81b414c20c6
Cr-Commit-Position: refs/heads/master@{#32416}

Powered by Google App Engine
This is Rietveld 408576698