gpu: Make sure external texture destination is initialized

gpu/command_buffer/service/gles2_cmd_decoder.cc

Index: gpu/command_buffer/service/gles2_cmd_decoder.cc
diff --git a/gpu/command_buffer/service/gles2_cmd_decoder.cc b/gpu/command_buffer/service/gles2_cmd_decoder.cc
index a97842748a229514d3b2d0e7c20b78911200ccf0..35ae1f06aca3273af9134ca128674a59e107ab16 100644
--- a/gpu/command_buffer/service/gles2_cmd_decoder.cc
+++ b/gpu/command_buffer/service/gles2_cmd_decoder.cc
@@ -9628,6 +9628,12 @@ void GLES2DecoderImpl::DoCopyTextureCHROMIUM(
   // Set source texture's width and height to be the same as
   // destination texture when source is GL_TEXTURE_EXTERNAL_OES.
   if (source_texture->target() == GL_TEXTURE_EXTERNAL_OES) {

[greggman, 2013/05/09 16:15:11]

Doesn't this code just need to move to about line 9665? The code at line 9641
will make the level exist

[Sami, 2013/05/09 16:18:43]

The problem is that for GL_TEXTURE_EXTERNAL, source_width and source_height are
both undefined so we can't really initialize the destination level directly. See
the comment on line 9579.

+    if (!dest_level_defined) {

[greggman, 2013/05/09 16:41:23]

Then please add a TODO: here that this coude should be removed. The contact for
CopyTextureCHROMIUM is that it creates the level. The client shouldn't have to
know the size. The comment above even says they need to provide a way to get the
width/height

[Sami, 2013/05/09 16:46:24]

Right, this is just a temporary safeguard while this code exist. I've duplicated
the TODO from above here.

+      LOCAL_SET_GL_ERROR(
+          GL_INVALID_VALUE,
+          "glCopyTextureCHROMIUM", "destination level not defined");
+      return;
+    }
     source_width = dest_width;
     source_height = dest_height;
   }