Issue 14858016: drive: Stop using callback for ResourceMetadataStorage::Iterate

Issue 14858016: drive: Stop using callback for ResourceMetadataStorage::Iterate (Closed)

Created:
7 years, 7 months ago by hashimoto

Modified:
7 years, 7 months ago

Reviewers:
hidehiko

CC:
chromium-reviews, tfarina, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

drive: Stop using callback for ResourceMetadataStorage::Iterate BUG=238999 TEST=unit_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199400

Patch Set 2 : rename methods #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+84 lines, -37 lines)			Patch
M	chrome/browser/chromeos/drive/resource_metadata.h	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/drive/resource_metadata.cc	View	1	1 chunk	+4 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/drive/resource_metadata_storage.h	View	1	4 chunks	+28 lines, -5 lines	0 comments	Download
M	chrome/browser/chromeos/drive/resource_metadata_storage.cc	View	1	3 chunks	+41 lines, -16 lines	0 comments	Download
M	chrome/browser/chromeos/drive/resource_metadata_storage_unittest.cc	View	1	4 chunks	+9 lines, -14 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

hidehiko

https://codereview.chromium.org/14858016/diff/2001/chrome/browser/chromeos/drive/resource_metadata_storage.h File chrome/browser/chromeos/drive/resource_metadata_storage.h (right): https://codereview.chromium.org/14858016/diff/2001/chrome/browser/chromeos/drive/resource_metadata_storage.h#newcode46 chrome/browser/chromeos/drive/resource_metadata_storage.h:46: void MoveForward(); How about name the methods Next()/Done() or ...

7 years, 7 months ago (2013-05-09 11:31:23 UTC) #2

hashimoto

7 years, 7 months ago (2013-05-09 11:48:46 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/14858016/5001

7 years, 7 months ago (2013-05-10 02:27:36 UTC) #5

Message was sent while issue was closed.

Change committed as 199400

Expand Messages | Collapse Messages