Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(675)

Side by Side Diff: Source/core/testing/Internals.cpp

Issue 14858004: Clean up the way layout tests force elements to opt in/out of composited scrolling. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: . Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * Copyright (C) 2013 Apple Inc. All rights reserved. 3 * Copyright (C) 2013 Apple Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 8 *
9 * 1. Redistributions of source code must retain the above copyright 9 * 1. Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 1608 matching lines...) Expand 10 before | Expand all | Expand 10 after
1619 if (flags & LAYER_TREE_INCLUDES_TILE_CACHES) 1619 if (flags & LAYER_TREE_INCLUDES_TILE_CACHES)
1620 layerTreeFlags |= LayerTreeFlagsIncludeTileCaches; 1620 layerTreeFlags |= LayerTreeFlagsIncludeTileCaches;
1621 if (flags & LAYER_TREE_INCLUDES_REPAINT_RECTS) 1621 if (flags & LAYER_TREE_INCLUDES_REPAINT_RECTS)
1622 layerTreeFlags |= LayerTreeFlagsIncludeRepaintRects; 1622 layerTreeFlags |= LayerTreeFlagsIncludeRepaintRects;
1623 if (flags & LAYER_TREE_INCLUDES_PAINTING_PHASES) 1623 if (flags & LAYER_TREE_INCLUDES_PAINTING_PHASES)
1624 layerTreeFlags |= LayerTreeFlagsIncludePaintingPhases; 1624 layerTreeFlags |= LayerTreeFlagsIncludePaintingPhases;
1625 1625
1626 return document->frame()->layerTreeAsText(layerTreeFlags); 1626 return document->frame()->layerTreeAsText(layerTreeFlags);
1627 } 1627 }
1628 1628
1629 void Internals::setNeedsCompositedScrolling(Element* element, unsigned needsComp ositedScrolling, ExceptionCode& ec)
1630 {
1631 if (!element) {
1632 ec = INVALID_ACCESS_ERR;
1633 return;
1634 }
1635
1636 element->document()->updateLayout();
1637
1638 RenderObject* renderer = element->renderer();
1639 if (!renderer || !renderer->isBox()) {
1640 ec = INVALID_ACCESS_ERR;
1641 return;
1642 }
1643
1644 RenderLayer* layer = toRenderBox(renderer)->layer();
1645 if (!layer) {
1646 ec = INVALID_ACCESS_ERR;
1647 return;
1648 }
1649
1650 layer->setForceNeedsCompositedScrolling(static_cast<RenderLayer::ForceNeedsC ompositedScrollingMode>(needsCompositedScrolling));
1651 }
1652
1629 String Internals::repaintRectsAsText(Document* document, ExceptionCode& ec) cons t 1653 String Internals::repaintRectsAsText(Document* document, ExceptionCode& ec) cons t
1630 { 1654 {
1631 if (!document || !document->frame()) { 1655 if (!document || !document->frame()) {
1632 ec = INVALID_ACCESS_ERR; 1656 ec = INVALID_ACCESS_ERR;
1633 return String(); 1657 return String();
1634 } 1658 }
1635 1659
1636 return document->frame()->trackedRepaintRectsAsText(); 1660 return document->frame()->trackedRepaintRectsAsText();
1637 } 1661 }
1638 1662
(...skipping 358 matching lines...) Expand 10 before | Expand all | Expand 10 after
1997 2021
1998 RenderObject* renderer = select->renderer(); 2022 RenderObject* renderer = select->renderer();
1999 if (!renderer->isMenuList()) 2023 if (!renderer->isMenuList())
2000 return false; 2024 return false;
2001 2025
2002 RenderMenuList* menuList = toRenderMenuList(renderer); 2026 RenderMenuList* menuList = toRenderMenuList(renderer);
2003 return menuList->popupIsVisible(); 2027 return menuList->popupIsVisible();
2004 } 2028 }
2005 2029
2006 } 2030 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698