base/metrics/histogram_base.cc - Issue 1485763002: Merge multiple histogram snapshots into single one for reporting.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/metrics/histogram_base.cc

Issue 1485763002: Merge multiple histogram snapshots into single one for reporting. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@shared-histograms

Patch Set: addressed remaining review comments by Alexei Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/metrics/histogram_base.cc

diff --git a/base/metrics/histogram_base.cc b/base/metrics/histogram_base.cc

index 412f1438d2fbde0b04a35c863dcba8b0e8e954dc..3a40e6813fc6f5c7669c627e4bbc007e6d7184d3 100644

--- a/base/metrics/histogram_base.cc

+++ b/base/metrics/histogram_base.cc

@@ -97,7 +97,7 @@ bool HistogramBase::SerializeInfo(Pickle* pickle) const {

return SerializeInfoImpl(pickle);

}

-int HistogramBase::FindCorruption(const HistogramSamples& samples) const {

+uint32_t HistogramBase::FindCorruption(const HistogramSamples& samples) const {

// Not supported by default.

return NO_INCONSISTENCIES;

}

« no previous file with comments | « base/metrics/histogram_base.h ('k') | base/metrics/histogram_persistence.cc » ('j') | no next file with comments »