components/metrics/metrics_service.h - Issue 1485763002: Merge multiple histogram snapshots into single one for reporting.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/metrics/metrics_service.h

Issue 1485763002: Merge multiple histogram snapshots into single one for reporting. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@shared-histograms

Patch Set: rebased Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/metrics/histogram_snapshot_manager_unittest.cc ('K') | « base/metrics/sparse_histogram.cc ('k') | components/metrics/metrics_service.cc » ('j') | components/metrics/metrics_service.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/metrics/metrics_service.h

diff --git a/components/metrics/metrics_service.h b/components/metrics/metrics_service.h

index ce4102b8dfa36408fe037bd6772184d759a48a4e..e5d79bcf3e276b5735dfe511c6f8ad7085108978 100644

--- a/components/metrics/metrics_service.h

+++ b/components/metrics/metrics_service.h

@@ -11,6 +11,7 @@

#include <stdint.h>

#include <map>

+#include <set>

#include <string>

#include <vector>

@@ -73,6 +74,8 @@ class MetricsService : public base::HistogramFlattener {

SHUTDOWN_COMPLETE = 700,

};

+ typedef std::set<base::HistogramBase*> HistogramSet;

Alexei Svitkine (slow) 2016/02/18 15:47:40 Doesn't seem like this is used anywhere in this CL

bcwhite 2016/02/18 17:07:05 Removed.

// Creates the MetricsService with the given |state_manager|, |client|, and

// |local_state|. Does not take ownership of the paramaters; instead stores

// a weak pointer to each. Caller should ensure that the parameters are valid