components/metrics/metrics_service.cc - Issue 1485763002: Merge multiple histogram snapshots into single one for reporting.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/metrics/metrics_service.cc

Issue 1485763002: Merge multiple histogram snapshots into single one for reporting. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@shared-histograms

Patch Set: rebased Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/metrics/metrics_service.cc

diff --git a/components/metrics/metrics_service.cc b/components/metrics/metrics_service.cc

index a69d8e82c1abc1f275fc8e7808b2a0e4b9343d43..63d5e7e8d8031aaa11557ec69939642ebc27f94c 100644

--- a/components/metrics/metrics_service.cc

+++ b/components/metrics/metrics_service.cc

@@ -1107,11 +1107,6 @@ void MetricsService::RecordCurrentEnvironment(MetricsLog* log) {

void MetricsService::RecordCurrentHistograms() {

DCHECK(log_manager_.current_log());

- // "true" indicates that StatisticsRecorder should include histograms in

Alexei Svitkine (slow) 2016/02/09 19:46:51 Why is this being removed?

bcwhite 2016/02/11 16:42:39 Done.

- // persistent storage.

- histogram_snapshot_manager_.PrepareDeltas(

- base::StatisticsRecorder::begin(true), base::StatisticsRecorder::end(),

- base::Histogram::kNoFlags, base::Histogram::kUmaTargetedHistogramFlag);

}

void MetricsService::RecordCurrentStabilityHistograms() {

« base/metrics/histogram_snapshot_manager.cc ('K') | « components/metrics/metrics_service.h ('k') | no next file » | no next file with comments »