chrome/chrome_browser.gypi - Issue 1485743002: Push API: test that default notification is shown on Android when needed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_browser.gypi

Issue 1485743002: Push API: test that default notification is shown on Android when needed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@PushMessagingInstrumentationTest

Patch Set: Address bauerb's comments. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/push_messaging/push_messaging_service_observer_android.cc ('k') | chrome/test/data/push_messaging/push_messaging_test_android.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/chrome_browser.gypi

diff --git a/chrome/chrome_browser.gypi b/chrome/chrome_browser.gypi

index 125dff3b831b6efbbb82914d148a98ed044c2a62..6ea2c34e28f3457af8549d33d601a84554edc9f9 100644

--- a/chrome/chrome_browser.gypi

+++ b/chrome/chrome_browser.gypi

@@ -469,6 +469,10 @@

'browser/push_messaging/push_messaging_service_factory.h',

'browser/push_messaging/push_messaging_service_impl.cc',

'browser/push_messaging/push_messaging_service_impl.h',

+ 'browser/push_messaging/push_messaging_service_observer.cc',

+ 'browser/push_messaging/push_messaging_service_observer.h',

+ 'browser/push_messaging/push_messaging_service_observer_android.cc',

+ 'browser/push_messaging/push_messaging_service_observer_android.h',

'browser/renderer_context_menu/context_menu_content_type_factory.cc',

'browser/renderer_context_menu/context_menu_content_type_factory.h',

'browser/renderer_context_menu/context_menu_content_type_panel.cc',

@@ -1865,6 +1869,7 @@

'android/java/src/org/chromium/chrome/browser/profiles/Profile.java',

'android/java/src/org/chromium/chrome/browser/profiles/ProfileDownloader.java',

'android/java/src/org/chromium/chrome/browser/prerender/ExternalPrerenderHandler.java',

+ 'android/java/src/org/chromium/chrome/browser/push_messaging/PushMessagingServiceObserver.java',

'android/java/src/org/chromium/chrome/browser/rappor/RapporServiceBridge.java',

'android/java/src/org/chromium/chrome/browser/rlz/RevenueStats.java',

'android/java/src/org/chromium/chrome/browser/ShortcutHelper.java',