Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7606)

Unified Diff: chrome/browser/push_messaging/push_messaging_service_impl.h

Issue 1485743002: Push API: test that default notification is shown on Android when needed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@PushMessagingInstrumentationTest
Patch Set: Address bauerb's comments. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/push_messaging/push_messaging_service_impl.h
diff --git a/chrome/browser/push_messaging/push_messaging_service_impl.h b/chrome/browser/push_messaging/push_messaging_service_impl.h
index c2c08bd15b70349060a3bd833383938f464c154d..b21200eab45da8d1fdbae68a111e69216cfee6d0 100644
--- a/chrome/browser/push_messaging/push_messaging_service_impl.h
+++ b/chrome/browser/push_messaging/push_messaging_service_impl.h
@@ -12,6 +12,7 @@
#include "base/callback.h"
#include "base/compiler_specific.h"
#include "base/gtest_prod_util.h"
+#include "base/memory/scoped_ptr.h"
#include "base/memory/weak_ptr.h"
#include "chrome/browser/background/background_trigger.h"
#include "components/content_settings/core/browser/content_settings_observer.h"
@@ -31,6 +32,7 @@
class Profile;
class PushMessagingAppIdentifier;
+class PushMessagingServiceObserver;
namespace gcm {
class GCMDriver;
@@ -131,6 +133,9 @@ class PushMessagingServiceImpl : public content::PushMessagingService,
const base::Closure& message_handled_closure,
content::PushDeliveryStatus status);
+ void DidHandleMessage(const std::string& app_id,
+ const base::Closure& completion_closure);
+
// Subscribe methods ---------------------------------------------------------
void SubscribeEnd(
@@ -231,6 +236,8 @@ class PushMessagingServiceImpl : public content::PushMessagingService,
MessageDispatchedCallback message_dispatched_callback_for_testing_;
+ scoped_ptr<PushMessagingServiceObserver> push_messaging_service_observer_;
+
base::WeakPtrFactory<PushMessagingServiceImpl> weak_factory_;
DISALLOW_COPY_AND_ASSIGN(PushMessagingServiceImpl);
« no previous file with comments | « chrome/browser/android/chrome_jni_registrar.cc ('k') | chrome/browser/push_messaging/push_messaging_service_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698