chrome/browser/push_messaging/push_messaging_service_observer.cc - Issue 1485743002: Push API: test that default notification is shown on Android when needed.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/push_messaging/push_messaging_service_observer.cc

Issue 1485743002: Push API: test that default notification is shown on Android when needed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@PushMessagingInstrumentationTest

Patch Set: Address bauerb's comments. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/push_messaging/push_messaging_service_observer.h ('k') | chrome/browser/push_messaging/push_messaging_service_observer_android.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "chrome/browser/push_messaging/push_messaging_service_observer.h"

	6

	7 #include "build/build_config.h"

	8

	9 #if defined(OS_ANDROID)

	10 #include "chrome/browser/push_messaging/push_messaging_service_observer_android. h"

	11 #endif

	12

	13 // static

	14 scoped_ptr<PushMessagingServiceObserver>

	15 PushMessagingServiceObserver::Create() {

	16 scoped_ptr<PushMessagingServiceObserver> observer;

	17 #if defined(OS_ANDROID)

	18 observer.reset(new PushMessagingServiceObserverAndroid());
	Bernhard Bauer 2015/12/11 16:35:57 You could also `return make_scoped_ptr(new ...)`, You could also `return make_scoped_ptr(new ...)`, but up to you. Michael van Ouwerkerk 2015/12/11 17:57:02 So a nullptr cannot be passed to make_scoped_ptr, Show quoted text On 2015/12/11 16:35:57, Bernhard Bauer wrote: > You could also `return make_scoped_ptr(new ...)`, but up to you. So a nullptr cannot be passed to make_scoped_ptr, but it can simply be returned and coerced into a scoped_ptr. Cool. Done.
	19 #endif

	20 return observer;

	21 }

OLD	NEW