Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Side by Side Diff: chrome/browser/push_messaging/push_messaging_service_observer.h

Issue 1485743002: Push API: test that default notification is shown on Android when needed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@PushMessagingInstrumentationTest
Patch Set: Address peter's comments. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef CHROME_BROWSER_PUSH_MESSAGING_PUSH_MESSAGING_SERVICE_OBSERVER_H_
6 #define CHROME_BROWSER_PUSH_MESSAGING_PUSH_MESSAGING_SERVICE_OBSERVER_H_
7
8 // Observes events and changes in the PushMessagingService.
9 //
10 // Note: this class is to be used in tests only.
Bernhard Bauer 2015/12/11 12:28:42 Name it ...ForTesting or ...TestingObserver then?
Michael van Ouwerkerk 2015/12/11 16:05:56 I've deleted this bit and expanded the comment in
11 class PushMessagingServiceObserver {
12 public:
13 // Creates a new PushMessagingServiceObserver. Caller takes ownership.
Bernhard Bauer 2015/12/11 12:28:42 Return a scoped_ptr then?
Michael van Ouwerkerk 2015/12/11 16:05:56 Done.
14 static PushMessagingServiceObserver* Create();
15
16 // Called when a push message has been fully handled.
17 virtual void OnMessageHandled() = 0;
18 };
19
20 #endif // CHROME_BROWSER_PUSH_MESSAGING_PUSH_MESSAGING_SERVICE_OBSERVER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698