Push API: test that default notification is shown on Android when needed.

chrome/browser/push_messaging/push_messaging_service_observer.cc

+// Copyright 2015 The Chromium Authors. All rights reserved.

[Peter Beverloo, 2015/12/10 18:47:51]

With an #ifdef you'd be able to avoid having this entire file. (With the two
if-defs in this file :).) Why did you choose for this solution?

Otherwise, please initialize push_messaging_service_observer_ in the
initialization list of the PushMessagingServiceImpl rather than in userland
constructor code.

[Michael van Ouwerkerk, 2015/12/11 11:23:54]

I'm not sure how you would avoid defining this file without adding ifdefs
elsewhere, as the Create method needs a definition. Initialization list done
though.

[Peter Beverloo, 2015/12/11 11:30:03]

My question is why we need the Create() method at all. Why not have
PushMessagingServiceObserver be a pure virtual interface and instantiate
PushMessagingServiceObserverAndroid directly?

[Michael van Ouwerkerk, 2015/12/11 11:38:24]

That would move the ifdef to the callsite. One of the reasons for having this
separate class at all is to reduce ifdefs in the PushMessagingServiceImpl.

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/push_messaging/push_messaging_service_observer.h"
+
+#include "build/build_config.h"
+
+#if defined(OS_ANDROID)
+#include "chrome/browser/push_messaging/push_messaging_service_observer_android.h"
+#endif
+
+// static
+PushMessagingServiceObserver* PushMessagingServiceObserver::Create() {
+#if defined(OS_ANDROID)
+  return new PushMessagingServiceObserverAndroid();
+#endif
+  return nullptr;
+}