Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 148573002: Add some histograms for <a ping> requests. (Closed)

Created:
6 years, 11 months ago by davidben
Modified:
6 years, 10 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, samarth, tburkard
Visibility:
Public.

Description

Add some histograms for <a ping> requests. So we can see if we're hitting the timeout, how long requests take, etc. BUG=302816 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247587

Patch Set 1 #

Patch Set 2 : histograms.xml #

Patch Set 3 : Throw in a newline #

Total comments: 10

Patch Set 4 : mmenke's comments #

Patch Set 5 : Restore timed_out_ check. #

Total comments: 2

Patch Set 6 : Reword comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -3 lines) Patch
M content/browser/loader/detachable_resource_handler.h View 1 2 3 3 chunks +12 lines, -0 lines 0 comments Download
M content/browser/loader/detachable_resource_handler.cc View 1 2 3 4 5 7 chunks +79 lines, -3 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +23 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
davidben
mmenke: Main review since you reviewed DetachableResourceHandler. asvitkine: For histograms.xml OWNERS. jam: content/ OWNERS samarth, ...
6 years, 11 months ago (2014-01-27 20:40:39 UTC) #1
jam
On 2014/01/27 20:40:39, David Benjamin wrote: > mmenke: Main review since you reviewed DetachableResourceHandler. > ...
6 years, 11 months ago (2014-01-27 21:35:17 UTC) #2
mmenke
https://codereview.chromium.org/148573002/diff/40001/content/browser/loader/detachable_resource_handler.cc File content/browser/loader/detachable_resource_handler.cc (right): https://codereview.chromium.org/148573002/diff/40001/content/browser/loader/detachable_resource_handler.cc#newcode20 content/browser/loader/detachable_resource_handler.cc:20: // Enum type for <a ping> result. Think you ...
6 years, 11 months ago (2014-01-27 22:51:54 UTC) #3
davidben
https://codereview.chromium.org/148573002/diff/40001/content/browser/loader/detachable_resource_handler.cc File content/browser/loader/detachable_resource_handler.cc (right): https://codereview.chromium.org/148573002/diff/40001/content/browser/loader/detachable_resource_handler.cc#newcode20 content/browser/loader/detachable_resource_handler.cc:20: // Enum type for <a ping> result. On 2014/01/27 ...
6 years, 10 months ago (2014-01-28 19:52:40 UTC) #4
Alexei Svitkine (slow)
lgtm
6 years, 10 months ago (2014-01-28 20:01:08 UTC) #5
mmenke
LGTM https://codereview.chromium.org/148573002/diff/80001/content/browser/loader/detachable_resource_handler.cc File content/browser/loader/detachable_resource_handler.cc (right): https://codereview.chromium.org/148573002/diff/80001/content/browser/loader/detachable_resource_handler.cc#newcode75 content/browser/loader/detachable_resource_handler.cc:75: // The request was aborted without OnResponseCompleted before ...
6 years, 10 months ago (2014-01-28 20:02:47 UTC) #6
davidben
https://codereview.chromium.org/148573002/diff/80001/content/browser/loader/detachable_resource_handler.cc File content/browser/loader/detachable_resource_handler.cc (right): https://codereview.chromium.org/148573002/diff/80001/content/browser/loader/detachable_resource_handler.cc#newcode75 content/browser/loader/detachable_resource_handler.cc:75: // The request was aborted without OnResponseCompleted before any ...
6 years, 10 months ago (2014-01-28 20:10:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davidben@chromium.org/148573002/100001
6 years, 10 months ago (2014-01-28 20:13:51 UTC) #8
commit-bot: I haz the power
6 years, 10 months ago (2014-01-29 02:00:25 UTC) #9
Message was sent while issue was closed.
Change committed as 247587

Powered by Google App Engine
This is Rietveld 408576698