src/typedarray.js - Issue 14857002: Allow pathological zero-length typed arrays.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/typedarray.js

Issue 14857002: Allow pathological zero-length typed arrays. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/typedarray.js

diff --git a/src/typedarray.js b/src/typedarray.js

index e105afc38e54799c8112320949232a008c835848..daade1328f22f6ae913285e823e0e3c7078cde53 100644

--- a/src/typedarray.js

+++ b/src/typedarray.js

@@ -93,7 +93,7 @@ function CreateTypedArrayConstructor(name, elementSize, arrayId, constructor) {

"start offset", name, elementSize);

}

var bufferByteLength = %ArrayBufferGetByteLength(buffer);

- if (offset >= bufferByteLength) {

+ if (offset > bufferByteLength) {

throw MakeRangeError("invalid_typed_array_offset");

}

« no previous file with comments | « no previous file | test/mjsunit/harmony/typedarrays.js » ('j') | no next file with comments »