Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1062)

Issue 1485673002: Switch case fall through property for the cases that have same case content. (Closed)

Created:
5 years ago by Deepak
Modified:
5 years ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Using switch case fall through property that have same case content, this will keep code concise and easy to understand. BUG=563443 Committed: https://crrev.com/5ea08518de62857b227345f8b5ed267cb7df03e8 Cr-Commit-Position: refs/heads/master@{#362633}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M base/prefs/json_pref_store.cc View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Deepak
PTAL
5 years ago (2015-11-30 14:12:59 UTC) #3
Bernhard Bauer
lgtm
5 years ago (2015-12-01 11:05:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1485673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1485673002/1
5 years ago (2015-12-02 03:36:28 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-02 04:40:40 UTC) #8
commit-bot: I haz the power
5 years ago (2015-12-02 04:41:43 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5ea08518de62857b227345f8b5ed267cb7df03e8
Cr-Commit-Position: refs/heads/master@{#362633}

Powered by Google App Engine
This is Rietveld 408576698