Add ability to retrieve cl commit bit on cmd line.

commit_queue.py

 #!/usr/bin/env python
 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Access the commit queue from the command line.
 """
 
 __version__ = '0.1'
 
@@ skipping 59 matching lines @@
         help='Rietveld server, default: %default')
     auth.add_auth_options(parser)
 
     # Call the original function with the modified parser.
     return fn(parser, args, *extra_args, **kwargs)
 
   hook.func_usage_more = '[options]'
   return hook
 
 
-def set_commit(obj, issue, flag):
-  """Sets the commit bit flag on an issue."""
+def _apply_on_issue(fun, obj, issue):

[tandrii(chromium), 2015/11/30 14:03:11]

well, if you are into making re-usable thing, why not make it like this:
  def _get_issue_properties(obj, issue):
    try: ...
    except:
      ...
      # instead of return 1
      sys.exit(1)

and use as nicely as

def get_commit(..):
  print int(_get_issue_properties(obj, issue)['commit'])

[Michael Achenbach, 2015/11/30 14:11:07]

I'm not entirely sure about the semantics of the callers. The expect a return
code and calling sys.exit(1) would circumvent this. E.g. the caller might have
some more logic and print additional help message or something...

+  """Applies function 'fun' on an issue."""
   try:
-    patchset = obj.get_issue_properties(issue, False)['patchsets'][-1]
-    print obj.set_flag(issue, patchset, 'commit', flag)
+    return fun(obj.get_issue_properties(issue, False))
   except urllib2.HTTPError, e:
     if e.code == 404:
       print >> sys.stderr, 'Issue %d doesn\'t exist.' % issue
     elif e.code == 403:
       print >> sys.stderr, 'Access denied to issue %d.' % issue
     else:
       raise
     return 1
 
+def get_commit(obj, issue):
+  """Gets the commit bit flag of an issue."""
+  def _get_commit(properties):
+    print int(properties['commit'])
+    return 0
+  _apply_on_issue(_get_commit, obj, issue)
+
+def set_commit(obj, issue, flag):
+  """Sets the commit bit flag on an issue."""
+  def _set_commit(properties):
+    print obj.set_flag(issue, properties['patchsets'][-1], 'commit', flag)
+    return 0
+  _apply_on_issue(_set_commit, obj, issue)
+
 @need_issue
 def CMDset(parser, args):
   """Sets the commit bit."""
   options, args, obj = parser.parse_args(args)
   if args:
     parser.error('Unrecognized args: %s' % ' '.join(args))
   return set_commit(obj, options.issue, '1')
 
+@need_issue
+def CMDget(parser, args):
+  """Gets the commit bit."""
+  options, args, obj = parser.parse_args(args)
+  if args:
+    parser.error('Unrecognized args: %s' % ' '.join(args))
+  return get_commit(obj, options.issue)
 
 @need_issue
 def CMDclear(parser, args):
   """Clears the commit bit."""
   options, args, obj = parser.parse_args(args)
   if args:
     parser.error('Unrecognized args: %s' % ' '.join(args))
   return set_commit(obj, options.issue, '0')
 
 
@@ skipping 131 matching lines @@
   return CMDhelp(parser, args)
 
 
 if __name__ == "__main__":
   fix_encoding.fix_encoding()
   try:
     sys.exit(main())
   except KeyboardInterrupt:
     sys.stderr.write('interrupted\n')
     sys.exit(1)