Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 1485643002: Drop the [Immutable] IDL extended attribute (it is a no-op) (Closed)

Created:
5 years ago by philipj_slow
Modified:
5 years ago
Reviewers:
haraken, bashi
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, blink-reviews-bindings_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Drop the [Immutable] IDL extended attribute (it is a no-op) It was only used for WebKitCSSMatrix, and the proposed spec for that does not use [Immutable]: https://compat.spec.whatwg.org/#webkitcssmatrix-interface Committed: https://crrev.com/96a6eaa930584b5a1d9fc4e29dc9f289c71cb7d3 Cr-Commit-Position: refs/heads/master@{#362137}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -19 lines) Patch
M third_party/WebKit/Source/bindings/IDLExtendedAttributes.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/idls/core/SVGTestInterface.idl View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/WebKitCSSMatrix.idl View 1 chunk +17 lines, -17 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1485643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1485643002/1
5 years ago (2015-11-30 12:40:08 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-11-30 13:45:42 UTC) #4
philipj_slow
PTAL
5 years ago (2015-11-30 13:47:57 UTC) #6
haraken
LGTM Historically [Immutable] was used by a bunch of SVG-related IDL files, but we've already ...
5 years ago (2015-11-30 14:14:59 UTC) #7
philipj_slow
On 2015/11/30 14:14:59, haraken wrote: > LGTM > > Historically [Immutable] was used by a ...
5 years ago (2015-11-30 15:58:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1485643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1485643002/1
5 years ago (2015-11-30 15:58:34 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-30 16:04:43 UTC) #11
commit-bot: I haz the power
5 years ago (2015-11-30 16:05:27 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/96a6eaa930584b5a1d9fc4e29dc9f289c71cb7d3
Cr-Commit-Position: refs/heads/master@{#362137}

Powered by Google App Engine
This is Rietveld 408576698