src/x64/lithium-x64.h - Issue 14856015: Bias commutative single-use register inputs and support lea adds

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/lithium-x64.h

Issue 14856015: Bias commutative single-use register inputs and support lea adds (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Review feedback Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/x64/lithium-x64.h

diff --git a/src/x64/lithium-x64.h b/src/x64/lithium-x64.h

index ccfb5b1dfb360db4ce9e5ef27c66019e64e5a22a..ad0b0d6c34d5b7874292c994833a7afc21a02de8 100644

--- a/src/x64/lithium-x64.h

+++ b/src/x64/lithium-x64.h

@@ -1345,6 +1345,11 @@ class LAddI: public LTemplateInstruction<1, 2, 0> {

LOperand* left() { return inputs_[0]; }

LOperand* right() { return inputs_[1]; }

+ static bool UseLea(HAdd* add) {

+ return !add->CheckFlag(HValue::kCanOverflow) &&

+ add->BetterLeftOperand()->UseCount() > 1;

+ }

DECLARE_CONCRETE_INSTRUCTION(AddI, "add-i")

DECLARE_HYDROGEN_ACCESSOR(Add)

};

« no previous file with comments | « src/x64/lithium-codegen-x64.cc ('k') | src/x64/lithium-x64.cc » ('j') | no next file with comments »