Source/core/platform/graphics/filters/FEComposite.cpp - Issue 14856010: Adding color space conversion code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/platform/graphics/filters/FEComposite.cpp

Issue 14856010: Adding color space conversion code (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fixing my ASCII art Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/platform/graphics/filters/FEComposite.cpp

diff --git a/Source/core/platform/graphics/filters/FEComposite.cpp b/Source/core/platform/graphics/filters/FEComposite.cpp

index 4b2b6535eed10bfce2cac508188b6be1971eae88..504fc8005a1cc43291e165420527c489bea2000c 100644

--- a/Source/core/platform/graphics/filters/FEComposite.cpp

+++ b/Source/core/platform/graphics/filters/FEComposite.cpp

@@ -391,8 +391,8 @@ SkXfermode::Mode toXfermode(WebCore::CompositeOperationType mode)

SkImageFilter* FEComposite::createImageFilter(SkiaImageFilterBuilder* builder)

{

- SkAutoTUnref<SkImageFilter> foreground(builder->build(inputEffect(0)));

- SkAutoTUnref<SkImageFilter> background(builder->build(inputEffect(1)));

+ SkAutoTUnref<SkImageFilter> foreground(builder->build(inputEffect(0), operatingColorSpace()));

+ SkAutoTUnref<SkImageFilter> background(builder->build(inputEffect(1), operatingColorSpace()));

if (m_type == FECOMPOSITE_OPERATOR_ARITHMETIC)

return 0; // FIXME: Implement arithmetic op

return new CompositeImageFilter(toXfermode(m_type), background, foreground);