Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 14856006: Docserver: achieve online vs offline (cron vs instance) behaviour at the object (Closed)

Created:
7 years, 7 months ago by not at google - send to devlin
Modified:
7 years, 7 months ago
Reviewers:
cduvall
CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Docserver: achieve online vs offline (cron vs instance) behaviour at the object store level, not at the caching file system level. This fixes the problem where the branch data and github data wasn't updating. Add a whole bunch of tests. BUG=167432

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : . #

Patch Set 4 : . #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+398 lines, -188 lines) Patch
M chrome/common/extensions/docs/server2/branch_utility.py View 1 chunk +3 lines, -6 lines 0 comments Download
M chrome/common/extensions/docs/server2/branch_utility_test.py View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/caching_file_system.py View 2 chunks +15 lines, -17 lines 0 comments Download
M chrome/common/extensions/docs/server2/caching_file_system_test.py View 1 9 chunks +26 lines, -18 lines 0 comments Download
M chrome/common/extensions/docs/server2/cron_servlet.py View 1 2 2 chunks +5 lines, -4 lines 0 comments Download
A chrome/common/extensions/docs/server2/cron_servlet_test.py View 1 2 1 chunk +27 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/server2/fake_fetchers.py View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/future.py View 1 2 1 chunk +1 line, -1 line 3 comments Download
M chrome/common/extensions/docs/server2/github_file_system.py View 2 chunks +8 lines, -6 lines 0 comments Download
M chrome/common/extensions/docs/server2/github_file_system_test.py View 1 2 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/server2/integration_test.py View 1 2 6 chunks +6 lines, -11 lines 0 comments Download
M chrome/common/extensions/docs/server2/local_file_system.py View 1 2 3 1 chunk +7 lines, -3 lines 0 comments Download
M chrome/common/extensions/docs/server2/local_renderer.py View 1 2 2 chunks +15 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/server2/object_store_creator.py View 1 5 chunks +50 lines, -11 lines 0 comments Download
M chrome/common/extensions/docs/server2/object_store_creator_test.py View 2 chunks +16 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/server2/preview.py View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/server2/render_servlet.py View 1 2 3 chunks +21 lines, -31 lines 0 comments Download
A chrome/common/extensions/docs/server2/render_servlet_test.py View 1 2 1 chunk +71 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/server2/samples_data_source.py View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/server2/server_instance.py View 1 2 3 chunks +68 lines, -63 lines 0 comments Download
A chrome/common/extensions/docs/server2/server_instance_test.py View 1 2 1 chunk +27 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/server2/test_object_store.py View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/test_util.py View 1 2 1 chunk +17 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
not at google - send to devlin
I should really test this... I'd like to write RenderServletTest and CronServletTest, and this would ...
7 years, 7 months ago (2013-05-02 16:29:56 UTC) #1
not at google - send to devlin
I ended up adding a whole bunch of tests, and needed to move some more ...
7 years, 7 months ago (2013-05-02 21:57:42 UTC) #2
cduvall
Started reviewing this, not sure what it was but this broke the branch chooser on ...
7 years, 7 months ago (2013-05-03 02:54:51 UTC) #3
方觉(Fang Jue)
https://chromiumcodereview.appspot.com/14856006/diff/8001/chrome/common/extensions/docs/server2/future.py File chrome/common/extensions/docs/server2/future.py (right): https://chromiumcodereview.appspot.com/14856006/diff/8001/chrome/common/extensions/docs/server2/future.py#newcode22 chrome/common/extensions/docs/server2/future.py:22: if self._value is not _no_value: If you're going to ...
7 years, 7 months ago (2013-05-03 06:03:31 UTC) #4
not at google - send to devlin
ugh, thanks Clark. I need to slow down and sit with a pen and paper ...
7 years, 7 months ago (2013-05-03 16:04:25 UTC) #5
cduvall
7 years, 7 months ago (2013-05-07 23:47:03 UTC) #6
Ben: should I wait to review this one?

https://chromiumcodereview.appspot.com/14856006/diff/8001/chrome/common/exten...
File chrome/common/extensions/docs/server2/future.py (right):

https://chromiumcodereview.appspot.com/14856006/diff/8001/chrome/common/exten...
chrome/common/extensions/docs/server2/future.py:22: if self._value is not
_no_value:
On 2013/05/03 16:04:25, kalman wrote:
> On 2013/05/03 06:03:31, 方觉(Fang Jue) wrote:
> > If you're going to use _no_value = (None,), be sure to compare with ==.
> > (None,) is not (None,)
> > (None,) == (None,)
> 
> "is not" is correct because the refer to the same value, no? python doesn't
copy
> by value, it copies by reference?

'is not' is correct.

Powered by Google App Engine
This is Rietveld 408576698