Finish removing WebKitSystemInterface from Blink.

Finish removing WebKitSystemInterface from Blink.

Replace some more WebKitSystemInterface wrappers with direct calls to SPI. This
also removes the library from the link list and deletes the now-unneeded 
adjust_visibility.sh script.

This is a partial revert of http://trac.webkit.org/changeset/9311, which
many years ago replaced these SPI calls with the WKSI ones.

This inlines a the call to WKGetVerticalGlyphsForCharacters(), which was a
noop that just returned false.

BUG=101156
R=thakis@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149659

[Nico, 2013-05-03 17:16:51]

Awesome!

One question below, all the other files look good.

https://codereview.chromium.org/14856004/diff/9001/Source/core/platform/graph...
File Source/core/platform/graphics/mac/GlyphPageTreeNodeMac.cpp (left):

https://codereview.chromium.org/14856004/diff/9001/Source/core/platform/graph...
Source/core/platform/graphics/mac/GlyphPageTreeNodeMac.cpp:75: } else if
(!fontData->platformData().isCompositeFontReference() &&
((fontData->platformData().widthVariant() == RegularWidth) ?
WKGetVerticalGlyphsForCharacters(fontData->platformData().ctFont(), buffer,
glyphs.data(), bufferLength)
This looks like a behavior change, not just like a replacement?

[Robert Sesek, 2013-05-03 17:58:03]

https://codereview.chromium.org/14856004/diff/9001/Source/core/platform/graph...
File Source/core/platform/graphics/mac/GlyphPageTreeNodeMac.cpp (left):

https://codereview.chromium.org/14856004/diff/9001/Source/core/platform/graph...
Source/core/platform/graphics/mac/GlyphPageTreeNodeMac.cpp:75: } else if
(!fontData->platformData().isCompositeFontReference() &&
((fontData->platformData().widthVariant() == RegularWidth) ?
WKGetVerticalGlyphsForCharacters(fontData->platformData().ctFont(), buffer,
glyphs.data(), bufferLength)
On 2013/05/03 17:16:51, Nico wrote:
> This looks like a behavior change, not just like a replacement?

Sorry, I forgot to call that out. The function does nothing:

_WKGetVerticalGlyphsForCharacters:
00000069        pushl   %ebp
0000006a        movl    %esp, %ebp
0000006c        xorl    %eax, %eax
0000006e        leave
0000006f        ret

[Nico, 2013-05-03 18:04:13]

:-D

Then lgtm, with "Inline the call to WKGetVerticalGlyphsForCharacters(), it's a
function that does nothing except return false" in the CL description.

Excited to see this go in!

[commit-bot: I haz the power, 2013-05-03 18:09:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rsesek@chromium.org/14856004/9001

[Robert Sesek, 2013-05-03 18:29:15]

Committed patchset #3 manually as r149659 (presubmit successful).

[abarth-chromium, 2013-05-06 05:30:28]

Awesome!