Remove SimpleBroker and instead use the production broker implementation in tests.

Remove SimpleBroker and instead use the production broker implementation in tests.

Now that we'll be using the broker for non-sandbox communication, all processes need to share state. This is better anyways to exercise the production code in tests.

BUG=561803
Committed: https://crrev.com/bfab778c21d4cb4656dc03205662cddf84ee4ac7
Cr-Commit-Position: refs/heads/master@{#362157}

[jam, 2015-11-30 16:11:41]

jam@chromium.org changed reviewers:
+ yzshen@chromium.org

[yzshen1, 2015-11-30 16:45:32]

LGTM with one nit

https://codereview.chromium.org/1485573002/diff/60001/mojo/edk/test/multiproc...
File mojo/edk/test/multiprocess_test_helper.cc (right):

https://codereview.chromium.org/1485573002/diff/60001/mojo/edk/test/multiproc...
mojo/edk/test/multiprocess_test_helper.cc:23: const char kBrokerHandleSwitch[] =
"broker-switch";
It seems "broker-handle" is more clear.

[jam, 2015-11-30 16:49:20]

https://codereview.chromium.org/1485573002/diff/60001/mojo/edk/test/multiproc...
File mojo/edk/test/multiprocess_test_helper.cc (right):

https://codereview.chromium.org/1485573002/diff/60001/mojo/edk/test/multiproc...
mojo/edk/test/multiprocess_test_helper.cc:23: const char kBrokerHandleSwitch[] =
"broker-switch";
On 2015/11/30 16:45:32, yzshen1 wrote:
> It seems "broker-handle" is more clear.

Done.

[jam, 2015-11-30 16:49:47]

The CQ bit was checked by jam@chromium.org

[jam, 2015-11-30 16:49:48]

The patchset sent to the CQ was uploaded after l-g-t-m from yzshen@chromium.org
Link to the patchset: https://codereview.chromium.org/1485573002/#ps80001
(title: "review comment")

[commit-bot: I haz the power, 2015-11-30 16:50:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1485573002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1485573002/80001

[commit-bot: I haz the power, 2015-11-30 17:54:46]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-11-30 17:55:31]

Description was changed from

==========
Remove SimpleBroker and instead use the production broker implementation in
tests.

Now that we'll be using the broker for non-sandbox communication, all processes
need to share state. This is better anyways to exercise the production code in
tests.

BUG=561803
==========

to

==========
Remove SimpleBroker and instead use the production broker implementation in
tests.

Now that we'll be using the broker for non-sandbox communication, all processes
need to share state. This is better anyways to exercise the production code in
tests.

BUG=561803

Committed: https://crrev.com/bfab778c21d4cb4656dc03205662cddf84ee4ac7
Cr-Commit-Position: refs/heads/master@{#362157}
==========

[commit-bot: I haz the power, 2015-11-30 17:55:32]

Patchset 5 (id:??) landed as
https://crrev.com/bfab778c21d4cb4656dc03205662cddf84ee4ac7
Cr-Commit-Position: refs/heads/master@{#362157}