media/audio/pulse/pulse_util.cc - Issue 148553003: Clean up histogram'd media enum max values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/audio/pulse/pulse_util.cc

Issue 148553003: Clean up histogram'd media enum max values. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: FOO_MAX = LAST_VALID_FOO Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/audio/pulse/pulse_util.cc

diff --git a/media/audio/pulse/pulse_util.cc b/media/audio/pulse/pulse_util.cc

index 96831cfabe3277fd165ec45b92995dad29978d72..86f96671498aaf324225aa5c6c35829ce0d23524 100644

--- a/media/audio/pulse/pulse_util.cc

+++ b/media/audio/pulse/pulse_util.cc

@@ -41,8 +41,6 @@ pa_channel_position ChromiumToPAChannelPosition(Channels channel) {

return PA_CHANNEL_POSITION_SIDE_LEFT;

case SIDE_RIGHT:

return PA_CHANNEL_POSITION_SIDE_RIGHT;

- case CHANNELS_MAX:

- return PA_CHANNEL_POSITION_INVALID;

default:

NOTREACHED() << "Invalid channel: " << channel;

return PA_CHANNEL_POSITION_INVALID;