media/base/channel_mixer_unittest.cc - Issue 148553003: Clean up histogram'd media enum max values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/base/channel_mixer_unittest.cc

Issue 148553003: Clean up histogram'd media enum max values. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: adjust comment Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/base/channel_mixer_unittest.cc

diff --git a/media/base/channel_mixer_unittest.cc b/media/base/channel_mixer_unittest.cc

index e048f8d9fc5811d41be77da66f82607439077426..c4634938bcf1ef1725583b2a75053c0745e61e35 100644

--- a/media/base/channel_mixer_unittest.cc

+++ b/media/base/channel_mixer_unittest.cc

@@ -21,7 +21,7 @@ enum { kFrames = 16 };

// Test all possible layout conversions can be constructed and mixed.

TEST(ChannelMixerTest, ConstructAllPossibleLayouts) {

for (ChannelLayout input_layout = CHANNEL_LAYOUT_MONO;

- input_layout < CHANNEL_LAYOUT_MAX;

+ input_layout < CHANNEL_LAYOUT_HISTOGRAM_MAX;

input_layout = static_cast<ChannelLayout>(input_layout + 1)) {

for (ChannelLayout output_layout = CHANNEL_LAYOUT_MONO;

output_layout < CHANNEL_LAYOUT_STEREO_DOWNMIX;