Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Unified Diff: media/base/video_decoder_config.h

Issue 148553003: Clean up histogram'd media enum max values. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/video_decoder_config.h
diff --git a/media/base/video_decoder_config.h b/media/base/video_decoder_config.h
index 3f7db4e6ca8b5a61ec7aec83101748e9fec0af29..8090a8f448c89bd976ce38b47fd7028ae0abfee4 100644
--- a/media/base/video_decoder_config.h
+++ b/media/base/video_decoder_config.h
@@ -18,8 +18,7 @@ namespace media {
enum VideoCodec {
// These values are histogrammed over time; do not change their ordinal
- // values. When deleting a codec replace it with a dummy value; when adding a
- // codec, do so at the bottom (and update kVideoCodecMax).
+ // values. When deleting a codec replace it with a dummy value.
kUnknownVideoCodec = 0,
kCodecH264,
kCodecVC1,
@@ -33,7 +32,8 @@ enum VideoCodec {
// The only acceptable time to add a new codec is if there is production code
// that uses said codec in the same CL.
- kVideoCodecMax = kCodecVP9 // Must equal the last "real" codec above.
+ // Must always be the last value:
+ kVideoCodecHistogramMax,
};
// Video stream profile. This *must* match PP_VideoDecoder_Profile.
@@ -62,7 +62,7 @@ enum VideoCodecProfile {
VP9PROFILE_MIN = 12,
VP9PROFILE_MAIN = VP9PROFILE_MIN,
VP9PROFILE_MAX = VP9PROFILE_MAIN,
- VIDEO_CODEC_PROFILE_MAX = VP9PROFILE_MAX,
+ VIDEO_CODEC_PROFILE_HISTOGRAM_MAX, // Must always be the last value.
};
class MEDIA_EXPORT VideoDecoderConfig {

Powered by Google App Engine
This is Rietveld 408576698