Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Side by Side Diff: media/base/channel_mixer_unittest.cc

Issue 148553003: Clean up histogram'd media enum max values. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // MSVC++ requires this to be set before any other includes to get M_SQRT1_2. 5 // MSVC++ requires this to be set before any other includes to get M_SQRT1_2.
6 #define _USE_MATH_DEFINES 6 #define _USE_MATH_DEFINES
7 7
8 #include <cmath> 8 #include <cmath>
9 9
10 #include "base/strings/stringprintf.h" 10 #include "base/strings/stringprintf.h"
11 #include "media/audio/audio_parameters.h" 11 #include "media/audio/audio_parameters.h"
12 #include "media/base/audio_bus.h" 12 #include "media/base/audio_bus.h"
13 #include "media/base/channel_mixer.h" 13 #include "media/base/channel_mixer.h"
14 #include "testing/gtest/include/gtest/gtest.h" 14 #include "testing/gtest/include/gtest/gtest.h"
15 15
16 namespace media { 16 namespace media {
17 17
18 // Number of frames to test with. 18 // Number of frames to test with.
19 enum { kFrames = 16 }; 19 enum { kFrames = 16 };
20 20
21 // Test all possible layout conversions can be constructed and mixed. 21 // Test all possible layout conversions can be constructed and mixed.
22 TEST(ChannelMixerTest, ConstructAllPossibleLayouts) { 22 TEST(ChannelMixerTest, ConstructAllPossibleLayouts) {
23 for (ChannelLayout input_layout = CHANNEL_LAYOUT_MONO; 23 for (ChannelLayout input_layout = CHANNEL_LAYOUT_MONO;
24 input_layout < CHANNEL_LAYOUT_MAX; 24 input_layout <= CHANNEL_LAYOUT_MAX;
25 input_layout = static_cast<ChannelLayout>(input_layout + 1)) { 25 input_layout = static_cast<ChannelLayout>(input_layout + 1)) {
26 for (ChannelLayout output_layout = CHANNEL_LAYOUT_MONO; 26 for (ChannelLayout output_layout = CHANNEL_LAYOUT_MONO;
27 output_layout < CHANNEL_LAYOUT_STEREO_DOWNMIX; 27 output_layout < CHANNEL_LAYOUT_STEREO_DOWNMIX;
28 output_layout = static_cast<ChannelLayout>(output_layout + 1)) { 28 output_layout = static_cast<ChannelLayout>(output_layout + 1)) {
29 // DISCRETE can't be tested here based on the current approach. 29 // DISCRETE can't be tested here based on the current approach.
30 if (input_layout == CHANNEL_LAYOUT_DISCRETE || 30 if (input_layout == CHANNEL_LAYOUT_DISCRETE ||
31 output_layout == CHANNEL_LAYOUT_DISCRETE) 31 output_layout == CHANNEL_LAYOUT_DISCRETE)
32 continue; 32 continue;
33 33
34 SCOPED_TRACE(base::StringPrintf( 34 SCOPED_TRACE(base::StringPrintf(
(...skipping 142 matching lines...) Expand 10 before | Expand all | Expand 10 after
177 kStereoToMonoValues, arraysize(kStereoToMonoValues)), 177 kStereoToMonoValues, arraysize(kStereoToMonoValues)),
178 ChannelMixerTestData(CHANNEL_LAYOUT_DISCRETE, 2, 178 ChannelMixerTestData(CHANNEL_LAYOUT_DISCRETE, 2,
179 CHANNEL_LAYOUT_DISCRETE, 5, 179 CHANNEL_LAYOUT_DISCRETE, 5,
180 kStereoToMonoValues, arraysize(kStereoToMonoValues)), 180 kStereoToMonoValues, arraysize(kStereoToMonoValues)),
181 ChannelMixerTestData(CHANNEL_LAYOUT_DISCRETE, 5, 181 ChannelMixerTestData(CHANNEL_LAYOUT_DISCRETE, 5,
182 CHANNEL_LAYOUT_DISCRETE, 2, 182 CHANNEL_LAYOUT_DISCRETE, 2,
183 kFiveDiscreteValues, arraysize(kFiveDiscreteValues)) 183 kFiveDiscreteValues, arraysize(kFiveDiscreteValues))
184 )); 184 ));
185 185
186 } // namespace media 186 } // namespace media
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698