Clean up histogram'd media enum max values.

media/audio/sample_rates.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MEDIA_AUDIO_SAMPLE_RATES_H_
 #define MEDIA_AUDIO_SAMPLE_RATES_H_
 
 #include "media/base/media_export.h"
 
 namespace media {
 
 // Enumeration used for histogramming sample rates into distinct buckets.
 // Logged to UMA, so never reuse a value, always add new/greater ones!
 enum AudioSampleRate {
   k8000Hz = 0,
   k16000Hz = 1,
   k32000Hz = 2,
   k48000Hz = 3,
   k96000Hz = 4,
   k11025Hz = 5,
   k22050Hz = 6,
   k44100Hz = 7,
   k88200Hz = 8,
   k176400Hz = 9,
   k192000Hz = 10,
-  kUnexpectedAudioSampleRate  // Must always be last!
+  kUnexpectedAudioSampleRate,
+  kAudioSampleRateMax =

[rileya (GONE FROM CHROMIUM), 2014/01/29 19:24:11]

This is a little iffy -- kUnexpectedAudioSampleRate sounds like a meaningful
value, but it's also used as the histogram cap. I added a max value to be
consistent with everything else, but adding a '+1' in the uma call seems
unnecessary if kUnexpectedAudioSampleRate was already used there...

[Ami GONE FROM CHROMIUM, 2014/01/29 21:29:02]

kUnexpected is a terrible fit since it doesn't get reported to UMA (hence the
weirdness w/ no explicit value and expected to change value if new rates are
added above it, even though this is a UMA-reported stat so should "never
change").
IMO set kAudioSampleRateMax = k192000Hz, drop kUnexpected, and take the hit on
changing
AudioSampleRate AsAudioSampleRate(int sample_rate);
to
bool ToAudioSampleRate(int sample_rate, AudioSampleRate* asr);
and return false if unexpected.

+      kUnexpectedAudioSampleRate,  // Must always equal last entry!

[Ami GONE FROM CHROMIUM, 2014/01/29 21:29:02]

FWIW, here and elsewhere, the real requirement (for UMA) is that this equal the
largest value ever used.  

 };
 
 // Helper method to convert integral values to their respective enum values,
 // or kUnexpectedAudioSampleRate if no match exists.
 MEDIA_EXPORT AudioSampleRate AsAudioSampleRate(int sample_rate);
 
 }  // namespace media
 
 #endif  // MEDIA_AUDIO_SAMPLE_RATES_H_