Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Unified Diff: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java

Issue 14855015: Report StaticWarningCode.NEW_WITH_NON_TYPE and CompileTimeErrorCode.CONST_WITH_NON_TYPE (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Fixes for review comments Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java
diff --git a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java
index 42e410952d52705e9220c599d45bb4a822c0e51e..816cb866b8589ff52a2247da0e2aa68cda1825ab 100644
--- a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java
+++ b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java
@@ -173,8 +173,10 @@ public enum CompileTimeErrorCode implements ErrorCode {
* x<sub>n+1</sub>: a<sub>n+1</sub>, &hellip; x<sub>n+k</sub>: a<sub>n+k</sub>)</i> it is a
* compile-time error if <i>T</i> is not a class accessible in the current scope, optionally
* followed by type arguments.
+ *
+ * @param name the name of the non-type element
*/
- CONST_WITH_NON_TYPE(""),
+ CONST_WITH_NON_TYPE("The name '%s' is not a class"),
/**
* 12.11.2 Const: It is a compile-time error if <i>T</i> includes any type parameters.
@@ -813,6 +815,12 @@ public enum CompileTimeErrorCode implements ErrorCode {
TYPE_ARGUMENTS_FOR_NON_GENERIC_CLASS(""),
/**
+ * 12.11.2 Const: It is a compile-time error if <i>T</i> is not a class accessible in the current
+ * scope, optionally followed by type arguments.
+ */
+ UNDEFINED_CLASS("Undefined class '%s'"),
+
+ /**
* 7.6.1 Generative Constructors: Let <i>C</i> be the class in which the superinitializer appears
* and let <i>S</i> be the superclass of <i>C</i>. Let <i>k</i> be a generative constructor. It is
* a compile-time error if class <i>S</i> does not declare a generative constructor named <i>S</i>

Powered by Google App Engine
This is Rietveld 408576698