Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 14855010: Use first position in LAllocator ordering heuristic. (Closed)

Created:
7 years, 7 months ago by Michael Starzinger
Modified:
7 years, 7 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Use first position in LAllocator ordering heuristic. This changes the tiebreaker for LAllocator's ordering heuristic of live ranges to use the first use position instead of the first hinted use position. Searching for the first hinted position introduces unnecessary overhead. R=jkummerow@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=14534

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/lithium-allocator.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
OK, now I am just feeling stupid. There go several hours profiling the register allocator ...
7 years, 7 months ago (2013-05-02 18:34:06 UTC) #1
Jakob Kummerow
lgtm
7 years, 7 months ago (2013-05-02 20:52:40 UTC) #2
Michael Starzinger
7 years, 7 months ago (2013-05-03 08:09:52 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r14534 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698