Drop [LegacyInterfaceTypeChecking] for the MIDI API

Drop [LegacyInterfaceTypeChecking] for the MIDI API

The added exception in the generated code is unreachable and thus
untestable, because there are two send() methods and the one changed
is only taken if the argument is of the correct type.

There are no internal calls where data could be null.

BUG=561338
Committed: https://crrev.com/85f6a195ab135d9b879d8031d0bb1b0d1069c4cd
Cr-Commit-Position: refs/heads/master@{#362392}

[philipj_slow, 2015-11-27 19:45:35]

The CQ bit was checked by philipj@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2015-11-27 19:45:43]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1485443002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1485443002/1

[philipj_slow, 2015-11-27 20:55:19]

philipj@opera.com changed reviewers:
+ kouhei@chromium.org, toyoshim@chromium.org, yhirano@chromium.org

[philipj_slow, 2015-11-27 20:55:19]

PTAL

[commit-bot: I haz the power, 2015-11-27 20:58:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-27 20:58:49]

Dry run: This issue passed the CQ dry run.

[philipj_slow, 2015-12-01 09:01:39]

Friendly ping :)

[Takashi Toyoshima, 2015-12-01 09:43:30]

Hi, thank you for working on this.
What's the user facing difference between before and after this change?

null and undefined argument will raise an exception on calling send()?

[yhirano, 2015-12-01 09:43:37]

lgtm

[philipj_slow, 2015-12-01 09:45:48]

The CQ bit was checked by philipj@opera.com

[commit-bot: I haz the power, 2015-12-01 09:46:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1485443002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1485443002/1

[philipj_slow, 2015-12-01 11:14:56]

On 2015/12/01 09:43:30, slow until Nov.15 wrote:
> Hi, thank you for working on this.
> What's the user facing difference between before and after this change?
> 
> null and undefined argument will raise an exception on calling send()?

Sorry, I missed this before sending to CQ. Because there are two send() methods,
there's type testing in order to pick one implementation, so the type checking
of the individual send() methods are redundant. Here's the generated code:

static void sendMethod(const v8::FunctionCallbackInfo<v8::Value>& info)
{
    ExceptionState exceptionState(ExceptionState::ExecutionContext, "send",
"MIDIOutput", info.Holder(), info.GetIsolate());
    switch (std::min(2, info.Length())) {
    case 1:
        if (V8Uint8Array::hasInstance(info[0], info.GetIsolate())) {
            send1Method(info);
            return;
        }
        if (info[0]->IsArray()) {
            send2Method(info);
            return;
        }
        break;
    case 2:
        if (V8Uint8Array::hasInstance(info[0], info.GetIsolate())) {
            send1Method(info);
            return;
        }
        if (info[0]->IsArray()) {
            send2Method(info);
            return;
        }
        break;
    default:
        break;
    }
    if (info.Length() < 1) {
        exceptionState.throwTypeError(ExceptionMessages::notEnoughArguments(1,
info.Length()));
        exceptionState.throwIfNeeded();
        return;
    }
    exceptionState.throwTypeError("No function was found that matched the
signature provided.");
    exceptionState.throwIfNeeded();
    return;
}

The change is inside send1Method, and is unreachable.

[commit-bot: I haz the power, 2015-12-01 11:40:10]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-12-01 11:40:58]

Description was changed from

==========
Drop [LegacyInterfaceTypeChecking] for the MIDI API

The added exception in the generated code is unreachable and thus
untestable, because there are two send() methods and the one changed
is only taken if the argument is of the correct type.

There are no internal calls where data could be null.

BUG=561338
==========

to

==========
Drop [LegacyInterfaceTypeChecking] for the MIDI API

The added exception in the generated code is unreachable and thus
untestable, because there are two send() methods and the one changed
is only taken if the argument is of the correct type.

There are no internal calls where data could be null.

BUG=561338

Committed: https://crrev.com/85f6a195ab135d9b879d8031d0bb1b0d1069c4cd
Cr-Commit-Position: refs/heads/master@{#362392}
==========

[commit-bot: I haz the power, 2015-12-01 11:40:58]

Patchset 1 (id:??) landed as
https://crrev.com/85f6a195ab135d9b879d8031d0bb1b0d1069c4cd
Cr-Commit-Position: refs/heads/master@{#362392}