Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Unified Diff: runtime/vm/assembler_mips.h

Issue 14854010: On MIPS, keeps Object::null() in a register. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/assembler_mips.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/assembler_mips.h
===================================================================
--- runtime/vm/assembler_mips.h (revision 22325)
+++ runtime/vm/assembler_mips.h (working copy)
@@ -574,16 +574,21 @@
// Addition of rs and rt with the result placed in rd.
// After, ro < 0 if there was signed overflow, ro >= 0 otherwise.
- // rd and ro must not be TMP1 or TMP2.
+ // rd and ro must not be TMP1.
// ro must be different from all the other registers.
- void AdduDetectOverflow(Register rd, Register rs, Register rt, Register ro);
+ // If rd, rs, and rt are the same register, then a scratch register different
+ // from the other registers is needed.
+ void AdduDetectOverflow(Register rd, Register rs, Register rt, Register ro,
+ Register scratch = kNoRegister);
// ro must be different from rd and rs.
- // rd and ro must not be TMP1 or TMP2
+ // rd and ro must not be TMP1.
+ // If rd and rs are the same, a scratch register different from the other
+ // registers is needed.
void AddImmediateDetectOverflow(Register rd, Register rs, int32_t imm,
- Register ro) {
+ Register ro, Register scratch = kNoRegister) {
LoadImmediate(rd, imm);
- AdduDetectOverflow(rd, rs, rd, ro);
+ AdduDetectOverflow(rd, rs, rd, ro, scratch);
}
// Subtraction of rt from rs (rs - rt) with the result placed in rd.
@@ -848,7 +853,7 @@
// enable easy access to the RawInstruction object of code corresponding
// to this frame.
void EnterDartFrame(intptr_t frame_size);
- void LeaveDartFrame();
+ void LeaveDartFrameAndReturn();
private:
AssemblerBuffer buffer_;
« no previous file with comments | « no previous file | runtime/vm/assembler_mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698