Make git-cl more accurately imitate git's editor selection process, and respect $VISUAL.

gclient_utils.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Generic utils."""
 
 import codecs
 import logging
 import os
 import Queue
@@ skipping 660 matching lines @@
         work_queue.exceptions.put(sys.exc_info())
       logging.info('_Worker.run(%s) done' % self.item.name)
 
       work_queue.ready_cond.acquire()
       try:
         work_queue.ready_cond.notifyAll()
       finally:
         work_queue.ready_cond.release()
 
 
-def GetEditor(git):
+def GetEditor(git, git_editor=None):
   """Returns the most plausible editor to use."""
+  terminal = os.environ.get('TERM')
+  terminal_is_dumb = not terminal or terminal == 'dumb'
   if git:
-    editor = os.environ.get('GIT_EDITOR')
+    editor = os.environ.get('GIT_EDITOR') or git_editor
   else:
     editor = os.environ.get('SVN_EDITOR')
+  if not editor and not (git and terminal_is_dumb):
+    editor = os.environ.get('VISUAL')
   if not editor:
     editor = os.environ.get('EDITOR')
   if not editor:
-    if sys.platform.startswith('win'):
+    if git and terminal_is_dumb:
+      editor = None

[M-A Ruel, 2013/05/02 14:13:48]

You assume we're going to call git here?

[jbroman, 2013/05/02 14:27:30]

I did this for completeness.

git-commit (et al) intentionally fail if they are on a dumb terminal, and none
of $GIT_EDITOR, core.editor and $EDITOR exists. This change imitates that. By
returning None, RunEditor also bails out. Above, it also ignores $VISUAL when it
thinks it's on a dumb terminal.

I'll revert the dumb terminal detection since it's of dubious value.

[M-A Ruel, 2013/05/02 14:35:17]

I'd prefer to document it then. There's no reference for any of the checks being
done here.

+    elif sys.platform.startswith('win'):
       editor = 'notepad'
     else:
       editor = 'vim'
   return editor
 
 
-def RunEditor(content, git):
+def RunEditor(content, git, git_editor=None):
   """Opens up the default editor in the system to get the CL description."""
   file_handle, filename = tempfile.mkstemp(text=True)
   # Make sure CRLF is handled properly by requiring none.
   if '\r' in content:
     print >> sys.stderr, (
         '!! Please remove \\r from your change description !!')
   fileobj = os.fdopen(file_handle, 'w')
   # Still remove \r if present.
   fileobj.write(re.sub('\r?\n', '\n', content))
   fileobj.close()
 
   try:
-    cmd = '%s %s' % (GetEditor(git), filename)
+    editor = GetEditor(git, git_editor=git_editor)
+    if not editor:
+      return None
+    cmd = '%s %s' % (editor, filename)
     if sys.platform == 'win32' and os.environ.get('TERM') == 'msys':
       # Msysgit requires the usage of 'env' to be present.
       cmd = 'env ' + cmd
     try:
       # shell=True to allow the shell to handle all forms of quotes in
       # $EDITOR.
       subprocess2.check_call(cmd, shell=True)
     except subprocess2.CalledProcessError:
       return None
     return FileRead(filename)
@@ skipping 43 matching lines @@
 
   Python on OSX 10.6 raises a NotImplementedError exception.
   """
   try:
     import multiprocessing
     return multiprocessing.cpu_count()
   except:  # pylint: disable=W0702
     # Mac OS 10.6 only
     # pylint: disable=E1101
     return int(os.sysconf('SC_NPROCESSORS_ONLN'))