Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 1485363002: Use invalidation sets for :lang changes. (Closed)

Created:
5 years ago by rune
Modified:
5 years ago
Reviewers:
tkent
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use invalidation sets for :lang changes. Modifying lang or xml:lang attributes caused a LocalStyleChange for the corresponding element in the presentational attribute check, but other elements may be affected using selector combinators. Use invalidation sets like we do for other pseudo classes. BUG=564331 Committed: https://crrev.com/c6397e4d6049de859b8aedc6299600ab55ba4944 Cr-Commit-Position: refs/heads/master@{#362675}

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Another rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/fast/css/invalidation/lang-pseudo.html View 1 chunk +49 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/css/invalidation/lang-pseudo-expected.txt View 1 chunk +19 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/RuleFeature.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Element.cpp View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLElement.cpp View 1 2 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 23 (12 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1485363002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1485363002/1
5 years ago (2015-12-02 00:08:52 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/101492) ios_rel_device_ninja on ...
5 years ago (2015-12-02 00:14:33 UTC) #4
rune
5 years ago (2015-12-02 00:26:20 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1485363002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1485363002/20001
5 years ago (2015-12-02 00:27:24 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/73853)
5 years ago (2015-12-02 00:46:51 UTC) #11
tkent
lgtm
5 years ago (2015-12-02 01:09:07 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1485363002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1485363002/20001
5 years ago (2015-12-02 07:04:02 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/74018)
5 years ago (2015-12-02 07:08:33 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1485363002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1485363002/40001
5 years ago (2015-12-02 08:50:04 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-12-02 10:15:11 UTC) #21
commit-bot: I haz the power
5 years ago (2015-12-02 10:15:56 UTC) #23
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c6397e4d6049de859b8aedc6299600ab55ba4944
Cr-Commit-Position: refs/heads/master@{#362675}

Powered by Google App Engine
This is Rietveld 408576698