Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1485353002: Expand generic type whitelist for function application checks (Closed)

Created:
5 years ago by vsm
Modified:
5 years ago
Reviewers:
Leaf
CC:
dev-compiler+reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Expand generic type whitelist for function application checks Hitting this in Angular - reusing the cast whitelist. R=leafp@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/835ec3f784330a71f42ec192b5be98ddd620c41c

Patch Set 1 #

Patch Set 2 : Cleanup #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M lib/runtime/dart/_operations.js View 2 chunks +10 lines, -3 lines 1 comment Download

Messages

Total messages: 6 (3 generated)
vsm
https://codereview.chromium.org/1485353002/diff/20001/lib/runtime/dart/_operations.js File lib/runtime/dart/_operations.js (right): https://codereview.chromium.org/1485353002/diff/20001/lib/runtime/dart/_operations.js#newcode232 lib/runtime/dart/_operations.js:232: if (obj == null) { This is an unrelated ...
5 years ago (2015-12-01 23:52:14 UTC) #3
Leaf
lgtm
5 years ago (2015-12-02 00:01:24 UTC) #4
vsm
5 years ago (2015-12-02 00:05:58 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
835ec3f784330a71f42ec192b5be98ddd620c41c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698